Making all system calls use paramter arguments

backdoor.cgi

@@ -175,4 +175,4 @@ foreach my $cc (split(/,/, $::FORM{'cc'})) {
 }
 
 print "Created bugzilla bug $zillaid\n";
-system("./processmail $zillaid");
+system("./processmail", $zillaid);

checksetup.pl

@@ -1668,7 +1668,7 @@ if ( CountIndexes('keywords') != 3 ) {
 # Final checks...
 if ($regenerateshadow) {
     print "Now regenerating the shadow database for all bugs.\n";
-    system("./processmail regenerate");
+    system("./processmail", "regenerate");
 }
 
 unlink "data/versioncache";

createattachment.cgi

@@ -106,7 +106,7 @@ What kind of file is this?
                   "Created an attachment (id=$attachid)\n$desc\n");
 
     print "<TABLE BORDER=1><TD><H2>Attachment to bug $id created</H2>\n";
-    system("./processmail $id $::COOKIE{'Bugzilla_login'}");
+    system("./processmail", $id, $::COOKIE{'Bugzilla_login'});
     print "<TD><A HREF=\"show_bug.cgi?id=$id\">Go Back to BUG# $id</A></TABLE>\n";
 }
 

doeditparams.cgi

@@ -73,7 +73,7 @@ WriteParams();
 
 unlink "data/versioncache";
 print "<PRE>";
-system("./syncshadowdb -v");
+system("./syncshadowdb", "-v");
 print "</PRE>";
 
 print "OK, done.<p>\n";

post_bug.cgi

@@ -229,7 +229,7 @@ foreach my $person (keys %ccids) {
 }
 
 print "<TABLE BORDER=1><TD><H2>Bug $id posted</H2>\n";
-system("./processmail $id $::COOKIE{'Bugzilla_login'}");
+system("./processmail", $id, $::COOKIE{'Bugzilla_login'});
 print "<TD><A HREF=\"show_bug.cgi?id=$id\">Back To BUG# $id</A></TABLE>\n";
 
 print "<BR><A HREF=\"createattachment.cgi?id=$id\">Attach a file to this bug</a>\n";

process_bug.cgi

@@ -512,7 +512,7 @@ SWITCH: for ($::FORM{'knob'}) {
         $::FORM{'comment'} .= "\n\n*** This bug has been marked as a duplicate of $num ***";
 
         print "<TABLE BORDER=1><TD><H2>Notation added to bug $num</H2>\n";
-        system("./processmail $num $::FORM{'who'}");
+        system("./processmail", $num, $::FORM{'who'});
         print "<TD><A HREF=\"show_bug.cgi?id=$num\">Go To BUG# $num</A></TABLE>\n";
 
         last SWITCH;
@@ -901,7 +901,7 @@ The changes made were:
 
     foreach my $k (keys(%dependencychanged)) {
         print "<TABLE BORDER=1><TD><H2>Checking for dependency changes on bug $k</H2>\n";
-        system("./processmail $k $::FORM{'who'}");
+        system("./processmail", $k, $::FORM{'who'});
         print "<TD><A HREF=\"show_bug.cgi?id=$k\">Go To BUG# $k</A></TABLE>\n";
     }