Bug 348282: importxml.pl throws Bugzilla::Bug::ValidateTime warnings if the time…

Bug 348282: importxml.pl throws Bugzilla::Bug::ValidateTime warnings if the time value is not defined and param timetrackinggroup defined - Patch by GuzmÃ¡n BrasÃ³ <gbn@hqso.net> r/a=LpSolit

Bug 348282: importxml.pl throws Bugzilla::Bug::ValidateTime warnings if the time…
121badd2 · lpsolit%gmail.com · ef1b5931 · 121badd2
Commit 121badd2 authored Feb 06, 2007 by lpsolit%gmail.com
Hide whitespace changes
Inline Side-by-side

Showing with 27 additions and 17 deletions

importxml.pl importxml.pl +27 -17

No files found.
--- a/importxml.pl
+++ b/importxml.pl
@@ -791,26 +791,36 @@ sub process_bug {
          || undef;
        push( @values, $date );
        push( @query,  "deadline" );
-        eval {
+        if ( defined $bug_fields{'estimated_time'} ) {
-            Bugzilla::Bug::ValidateTime($bug_fields{'estimated_time'}, "e");
+            eval {
-        };
+                Bugzilla::Bug::ValidateTime($bug_fields{'estimated_time'}, "e");
-        if (!$@){
+            };
-            push( @values, $bug_fields{'estimated_time'} );
+            if (!$@){
-            push( @query,  "estimated_time" );
+                push( @values, $bug_fields{'estimated_time'} );
+                push( @query,  "estimated_time" );
+            }
        }
-        eval {
+        if ( defined $bug_fields{'remaining_time'} ) {
-            Bugzilla::Bug::ValidateTime($bug_fields{'remaining_time'}, "r");
+            eval {
-        };
+                Bugzilla::Bug::ValidateTime($bug_fields{'remaining_time'}, "r");
-        if (!$@){
+            };
-            push( @values, $bug_fields{'remaining_time'} );
+            if (!$@){
-            push( @query,  "remaining_time" );
+                push( @values, $bug_fields{'remaining_time'} );
+                push( @query,  "remaining_time" );
+            }
        }
-        eval {
+        if ( defined $bug_fields{'actual_time'} ) {
-            Bugzilla::Bug::ValidateTime($bug_fields{'actual_time'}, "a");
+            eval {
-        };
+                Bugzilla::Bug::ValidateTime($bug_fields{'actual_time'}, "a");
-        if ($@){
+            };
+            if ($@){
+                $bug_fields{'actual_time'} = 0.0;
+                $err .= "Invalid Actual Time. Setting to 0.0\n";
+            }
+        }
+        else {
            $bug_fields{'actual_time'} = 0.0;
-            $err .= "Invalid Actual Time. Setting to 0.0\n";
+            $err .= "Actual time not defined. Setting to 0.0\n";
        }
    }