Commit 5ab9af11 authored by Frédéric Buclin's avatar Frédéric Buclin

Backout 1st part of bug 340160: state $sth doesn't work fine with mod_perl

parent c88c3c0a
...@@ -3954,11 +3954,7 @@ sub get_activity { ...@@ -3954,11 +3954,7 @@ sub get_activity {
# Update the bugs_activity table to reflect changes made in bugs. # Update the bugs_activity table to reflect changes made in bugs.
sub LogActivityEntry { sub LogActivityEntry {
my ($i, $col, $removed, $added, $whoid, $timestamp, $comment_id) = @_; my ($i, $col, $removed, $added, $whoid, $timestamp, $comment_id) = @_;
state $sth = my $dbh = Bugzilla->dbh;
Bugzilla->dbh->prepare('INSERT INTO bugs_activity
(bug_id, who, bug_when, fieldid, removed, added, comment_id)
VALUES (?, ?, ?, ?, ?, ?, ?)');
# in the case of CCs, deps, and keywords, there's a possibility that someone # in the case of CCs, deps, and keywords, there's a possibility that someone
# might try to add or remove a lot of them at once, which might take more # might try to add or remove a lot of them at once, which might take more
# space than the activity table allows. We'll solve this by splitting it # space than the activity table allows. We'll solve this by splitting it
...@@ -3982,7 +3978,10 @@ sub LogActivityEntry { ...@@ -3982,7 +3978,10 @@ sub LogActivityEntry {
trick_taint($addstr); trick_taint($addstr);
trick_taint($removestr); trick_taint($removestr);
my $fieldid = get_field_id($col); my $fieldid = get_field_id($col);
$sth->execute($i, $whoid, $timestamp, $fieldid, $removestr, $addstr, $comment_id); $dbh->do("INSERT INTO bugs_activity
(bug_id, who, bug_when, fieldid, removed, added, comment_id)
VALUES (?, ?, ?, ?, ?, ?, ?)",
undef, ($i, $whoid, $timestamp, $fieldid, $removestr, $addstr, $comment_id));
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment