Bug 240439: "Edit user again" link didn't work if the user had a + in their email address

R= timeless, vladd; a= justdave
parent 6d413a7c
...@@ -844,7 +844,7 @@ if ($action eq 'update') { ...@@ -844,7 +844,7 @@ if ($action eq 'update') {
if ($editall && $user ne $userold) { if ($editall && $user ne $userold) {
unless ($user) { unless ($user) {
print "Sorry, I can't delete the user's name."; print "Sorry, I can't delete the user's name.";
$userold = value_quote($userold); $userold = url_quote($userold);
$localtrailer =~ s/XXX/$userold/; $localtrailer =~ s/XXX/$userold/;
push @localtrailers, $localtrailer; push @localtrailers, $localtrailer;
PutTrailer(@localtrailers); PutTrailer(@localtrailers);
...@@ -852,7 +852,7 @@ if ($action eq 'update') { ...@@ -852,7 +852,7 @@ if ($action eq 'update') {
} }
if (TestUser($user)) { if (TestUser($user)) {
print "Sorry, user name '$user' is already in use."; print "Sorry, user name '$user' is already in use.";
$userold = value_quote($userold); $userold = url_quote($userold);
$localtrailer =~ s/XXX/$userold/; $localtrailer =~ s/XXX/$userold/;
push @localtrailers, $localtrailer; push @localtrailers, $localtrailer;
PutTrailer($localtrailer); PutTrailer($localtrailer);
...@@ -864,12 +864,12 @@ if ($action eq 'update') { ...@@ -864,12 +864,12 @@ if ($action eq 'update') {
WHERE login_name=" . SqlQuote($userold)); WHERE login_name=" . SqlQuote($userold));
print q|Updated user's name to <a href="mailto:| . print q|Updated user's name to <a href="mailto:| .
value_quote($user) . '">' . html_quote($user) . "</a>.<BR>\n"; url_quote($user) . '">' . html_quote($user) . "</a>.<BR>\n";
} }
my $changeduser = new Bugzilla::User($thisuserid); my $changeduser = new Bugzilla::User($thisuserid);
$changeduser->derive_groups(); $changeduser->derive_groups();
$user = value_quote($user); $user = url_quote($user);
$localtrailer =~ s/XXX/$user/; $localtrailer =~ s/XXX/$user/;
push @localtrailers, $localtrailer; push @localtrailers, $localtrailer;
PutTrailer(@localtrailers); PutTrailer(@localtrailers);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment