Bug 652663 - When using bug_format_comment hook some replacements can happen…

Bug 652663 - When using bug_format_comment hook some replacements can happen more than once causing broken links r/a=LpSolit

Bug 652663 - When using bug_format_comment hook some replacements can happen…
7ddff2f3 · David Lawrence · 2686b79f · 7ddff2f3
Commit 7ddff2f3 authored Jul 25, 2011 by David Lawrence
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

Template.pm Bugzilla/Template.pm +4 -2

No files found.
--- a/Bugzilla/Template.pm
+++ b/Bugzilla/Template.pm
@@ -264,8 +264,10 @@ sub quoteUrls {
              ~get_bug_link($1, $1)
              ~egmx;
-    # Now remove the encoding hacks
+    # Now remove the encoding hacks in reverse order
-    $text =~ s/\0\0(\d+)\0\0/$things[$1]/eg;
+    for (my $i = $#things; $i >= 0; $i--) {
+        $text =~ s/\0\0($i)\0\0/$things[$i]/eg;
+    }
    $text =~ s/$chr1\0/\0/g;
    return $text;