Bug 460752: Move hardcoded CSS from attachment/diff-header.html.tmpl into a…

Bug 460752: Move hardcoded CSS from attachment/diff-header.html.tmpl into a separate CSS file - Patch by FrÃ©dÃ©ric Buclin <LpSolit@gmail.com> r=ghendricks a=LpSolit

Bug 460752: Move hardcoded CSS from attachment/diff-header.html.tmpl into a…
8b8bef25 · lpsolit%gmail.com · 8cb33cb1 · 8b8bef25 · 8b8bef25
Commit 8b8bef25 authored Dec 09, 2008 by lpsolit%gmail.com
Hide whitespace changes
Inline Side-by-side

Showing with 73 additions and 74 deletions

create_attachment.css skins/standard/create_attachment.css +70 -0

diff-header.html.tmpl template/en/default/attachment/diff-header.html.tmpl +3 -74

No files found.
--- a/skins/standard/create_attachment.css
+++ b/skins/standard/create_attachment.css
@@ -34,3 +34,73 @@ table#flags td {
    vertical-align: baseline;
    font-size: small;
 }
+
+/* Rules used to view patches in diff mode. */
+
+.file_head {
+  font-weight: bold;
+  font-size: 1em;
+  background-color: #c3c3c3;
+  border: 1px solid black;
+}
+
+.file_head a {
+  text-decoration: none;
+  font-family: monospace;
+  font-size: 1.1em;
+}
+
+.file_collapse {
+  display: none;
+}
+
+.section_head {
+  background-color: #f0f0f0;
+  border: 1px solid black;
+  text-align: left;
+}
+
+table.file_table {
+  table-layout: fixed;
+  width: 100%;
+  empty-cells: show;
+  border-spacing: 0px;
+  border-collapse: collapse;
+  /* draw border below last open context section in listing */
+  border-bottom: 1px solid black;
+}
+
+tbody.file pre {
+  display: inline;
+  white-space: pre-wrap; /* CSS 3 & CSS 2.1 */
+  white-space: -moz-pre-wrap; /* Gecko < 1.9.1 */
+  white-space: -o-pre-wrap; /* Opera 7 */
+  font-size: 0.9em;
+}
+
+tbody.file pre:empty {
+  display: block;
+}
+
+.changed {
+  background-color: lightblue;
+}
+
+.added {
+  background-color: lightgreen;
+}
+
+.removed {
+  background-color: #FFCC99;
+}
+
+.num {
+  background-color: #ffe9ae;
+  text-align:right;
+  padding: 0 0.3em;
+  width: 3em;
+}
+
+.warning {
+  color: red
+}
--- a/template/en/default/attachment/diff-header.html.tmpl
+++ b/template/en/default/attachment/diff-header.html.tmpl
@@ -30,76 +30,6 @@ Interdiff of #[% oldid %] and #[% newid %] for [% terms.bug %] #[% bugid %]
  [% END %]
 [% END %]

-[% style = BLOCK %]
-.file_head {
-  font-weight: bold;
-  font-size: 1em;
-  background-color: #c3c3c3;
-  border: 1px solid black;
-}
-
-.file_head a {
-  text-decoration: none; 
-  font-family: monospace; 
-  font-size: 1.1em;
-}
-
-.file_collapse {
-  display: none;
-}
-
-.section_head {
-  background-color: #f0f0f0;
-  border: 1px solid black;
-  text-align: left;
-}
-
-table.file_table {
-  table-layout: fixed;
-  width: 100%;
-  empty-cells: show;
-  border-spacing: 0px;
-  border-collapse: collapse;
-  /* draw border below last open context section in listing */
-  border-bottom: 1px solid black;
-}
-
-tbody.file pre {
-  display: inline;
-  white-space: pre-wrap; /* CSS 3 & CSS 2.1 */
-  white-space: -moz-pre-wrap; /* Gecko < 1.9.1 */
-  white-space: -o-pre-wrap; /* Opera 7 */
-  font-size: 0.9em;
-}
-
-tbody.file pre:empty {
-  display: block;
-}
-
-.changed {
-  background-color: lightblue;
-}
-
-.added {
-  background-color: lightgreen;
-}
-
-.removed {
-  background-color: #FFCC99;
-}
-
-.num {
-  background-color: #ffe9ae;
-  text-align:right;
-  padding: 0 0.3em;
-  width: 3em;
-}
-
-.warning {
-  color: red
-}
-[% END %]
-
 [% onload = 'restore_all(); document.checkboxform.restore_indicator.checked = true' %]

 [% BLOCK viewurl %]attachment.cgi?id=[% id %][% END %]
@@ -122,13 +52,12 @@ tbody.file pre:empty {
    [% bugsummary FILTER html %]
  [% END %]
  [% PROCESS global/header.html.tmpl doc_section = "attachments.html#patchviewer"
-                                     javascript_urls = "js/attachment.js" %]
+                                     javascript_urls = "js/attachment.js"
+                                     style_urls = ['skins/standard/create_attachment.css'] %]
 [% ELSE %]
  <html>
  <head>
-  <style type="text/css">
-  [% style %]
-  </style>
+  <link href="skins/standard/create_attachment.css" rel="stylesheet" type="text/css">
  <script src="js/attachment.js" type="text/javascript"></script>
  </head>
  <body onload="[% onload FILTER html %]">