Bug 106918: the "movers" param was not being interpreted correctly by move.pl or…

Bug 106918: the "movers" param was not being interpreted correctly by move.pl or the show_bug template. Also the exporter value was not properly fed into the xml template. r= myk, a= justdave

Bug 106918: the "movers" param was not being interpreted correctly by move.pl or…
8f0598f4 · justdave%syndicomm.com · b996f2f7 · 8f0598f4 · 8f0598f4 · 8f0598f4
Commit 8f0598f4 authored Jan 24, 2003 by justdave%syndicomm.com
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 2 deletions

Bug.pm Bug.pm +2 -0

Bug.pm Bugzilla/Bug.pm +2 -0

move.pl move.pl +2 -2

No files found.
--- a/Bug.pm
+++ b/Bug.pm
@@ -362,6 +362,8 @@ sub user {
    $self->{'user'} = {};

    my $movers = Param("movers");
+    $movers =~ s/\s?,\s?/|/g;
+    $movers =~ s/@/\@/g;
    $self->{'user'}->{'canmove'} = Param("move-enabled") 
      && (defined $::COOKIE{"Bugzilla_login"}) 
        && ($::COOKIE{"Bugzilla_login"} =~ /$movers/);

--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -362,6 +362,8 @@ sub user {
    $self->{'user'} = {};

    my $movers = Param("movers");
+    $movers =~ s/\s?,\s?/|/g;
+    $movers =~ s/@/\@/g;
    $self->{'user'}->{'canmove'} = Param("move-enabled") 
      && (defined $::COOKIE{"Bugzilla_login"}) 
        && ($::COOKIE{"Bugzilla_login"} =~ /$movers/);

--- a/move.pl
+++ b/move.pl
@@ -86,7 +86,7 @@ if ( !defined $::FORM{'buglist'} ) {

 my $exporter = $::COOKIE{"Bugzilla_login"};
 my $movers = Param("movers");
-$movers =~ s/\w?,\w?/|/g;
+$movers =~ s/\s?,\s?/|/g;
 $movers =~ s/@/\@/g;
 unless ($exporter =~ /($movers)/) {
  print "Content-type: text/html\n\n";
@@ -149,7 +149,7 @@ $from =~ s/@/\@/;
 $msg .= "From: Bugzilla <" . $from . ">\n";
 $msg .= "Subject: Moving bug(s) $buglist\n\n";

-$template->process("bug/show.xml.tmpl", { bugs => \@bugs }, \$msg)
+$template->process("bug/show.xml.tmpl", { user => { login => $exporter }, bugs => \@bugs }, \$msg)
  || ThrowTemplateError($template->error());

 $msg .= "\n";