Commit 8f893f4d authored by wurblzap%gmail.com's avatar wurblzap%gmail.com

Bug 306695: Boolean charts forgets "0" values.

Patch by Marc Schumann <wurblzap@gmail.com>, r=LpSolit, bugreport, a=justdave
parent 9fc0498b
...@@ -116,7 +116,7 @@ sub canonicalise_query { ...@@ -116,7 +116,7 @@ sub canonicalise_query {
my $esc_key = url_quote($key); my $esc_key = url_quote($key);
foreach my $value ($self->param($key)) { foreach my $value ($self->param($key)) {
if ($value) { if (defined($value)) {
my $esc_value = url_quote($value); my $esc_value = url_quote($value);
push(@parameters, "$esc_key=$esc_value"); push(@parameters, "$esc_key=$esc_value");
......
...@@ -314,9 +314,13 @@ for (my $chart = 0; $cgi->param("field$chart-0-0"); $chart++) { ...@@ -314,9 +314,13 @@ for (my $chart = 0; $cgi->param("field$chart-0-0"); $chart++) {
for (my $row = 0; $cgi->param("field$chart-$row-0"); $row++) { for (my $row = 0; $cgi->param("field$chart-$row-0"); $row++) {
my @cols; my @cols;
for (my $col = 0; $cgi->param("field$chart-$row-$col"); $col++) { for (my $col = 0; $cgi->param("field$chart-$row-$col"); $col++) {
my $value = $cgi->param("value$chart-$row-$col");
if (!defined($value)) {
$value = '';
}
push(@cols, { field => $cgi->param("field$chart-$row-$col"), push(@cols, { field => $cgi->param("field$chart-$row-$col"),
type => $cgi->param("type$chart-$row-$col") || 'noop', type => $cgi->param("type$chart-$row-$col") || 'noop',
value => $cgi->param("value$chart-$row-$col") || '' }); value => $value });
} }
push(@rows, \@cols); push(@rows, \@cols);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment