Commit 94e43ad5 authored by Frédéric Buclin's avatar Frédéric Buclin

Bug 924802: (CVE-2013-1742) [SECURITY] (XSS) "id" and "sortkey" are not…

Bug 924802: (CVE-2013-1742) [SECURITY] (XSS) "id" and "sortkey" are not sanitized when editing flag types if categoryAction-foo is set r=dkl a=glob
parent 362e6897
......@@ -36,7 +36,7 @@
<form id="flagtype_properties" method="post" action="editflagtypes.cgi">
<input type="hidden" name="action" value="[% action FILTER html %]">
<input type="hidden" name="can_fully_edit" value="[% can_fully_edit FILTER html %]">
<input type="hidden" name="id" value="[% type.id %]">
<input type="hidden" name="id" value="[% type.id FILTER html %]">
<input type="hidden" name="token" value="[% token FILTER html %]">
<input type="hidden" name="target_type" value="[% type.target_type FILTER html %]">
<input type="hidden" name="check_clusions" value="[% check_clusions FILTER none %]">
......@@ -133,8 +133,8 @@
this type will be sorted when displayed to users in a list; ignore if you
don't care what order the types appear in or if you want them to appear
in alphabetical order.<br>
<input type="text" name="sortkey" value="[% type.sortkey || 0 %]" size="5" maxlength="5"
[%- ' disabled="disabled"' UNLESS can_fully_edit %]>
<input type="text" name="sortkey" value="[% type.sortkey || 0 FILTER html %]" size="5"
maxlength="5" [% ' disabled="disabled"' UNLESS can_fully_edit %]>
</td>
</tr>
......
......@@ -386,8 +386,6 @@
],
'admin/flag-type/edit.html.tmpl' => [
'type.id',
'type.sortkey || 0',
'selname',
],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment