* Disable the Voting extension by default.

* There was a syntax error in the code-error-errors.html.tmpl hook in the Voting extension. * Creating the TestProduct during checksetup was throwing an warning about use of an uninitialized value, due to the Voting extension. https://bugzilla.mozilla.org/show_bug.cgi?id=372979

* Disable the Voting extension by default.
bcd2c583 · Max Kanat-Alexander · 013e7055 · bcd2c583 · bcd2c583 · bcd2c583
Commit bcd2c583 authored Feb 15, 2010 by Max Kanat-Alexander
Showing with 2 additions and 1 deletion

Extension.pm extensions/Voting/Extension.pm +1 -1

disabled extensions/Voting/disabled +0 -0

code-error-errors.html.tmpl ...mplate/en/default/hook/global/code-error-errors.html.tmpl +1 -0

No files found.
--- a/extensions/Voting/Extension.pm
+++ b/extensions/Voting/Extension.pm
@@ -326,7 +326,7 @@ sub _check_votestoconfirm {
 sub _check_votes {
    my ($default, $invocant, $votes, $field) = @_;

-    detaint_natural($votes);
+    detaint_natural($votes) if defined $votes;
    # On product creation, if the number of votes is not a valid integer,
    # we silently fall back to the given default value.
    # If the product already exists and the change is illegal, we complain.

--- a/extensions/Voting/disabled
+++ b/extensions/Voting/disabled
--- a/extensions/Voting/template/en/default/hook/global/code-error-errors.html.tmpl
+++ b/extensions/Voting/template/en/default/hook/global/code-error-errors.html.tmpl
@@ -22,3 +22,4 @@
    [% title = "$terms.Bug Cannot Be Confirmed" %]
    There is no valid transition from
    [%+ display_value("bug_status", "UNCONFIRMED") FILTER html %] to an open state
+[% END %]