Skip to content

bugzilla
bugzilla
Commit dbce51e8 authored by bugreport%peshkin.net's avatar bugreport%peshkin.net
Browse files
Options

Bug 227191: Change DBI->connect syntax so database password will not be revealed if connect fails

r=bbaetz a=justdave
parent 1ade641d
Hide whitespace changes
Inline Side-by-side
Showing with 5 additions and 3 deletions
Bugzilla/DB.pm
View file @ dbce51e8
...@@ -144,10 +144,12 @@ sub _connect { ...@@ -144,10 +144,12 @@ sub _connect {
# connect using our known info to the specified db # connect using our known info to the specified db
# Apache::DBI will cache this when using mod_perl # Apache::DBI will cache this when using mod_perl
my $dbh = DBI->connect($dsn, my $dbh = DBI->connect($dsn,
$db_user, '',
$db_pass, '',
{ RaiseError => 1, { RaiseError => 1,
PrintError => 0, PrintError => 0,
Username => $db_user,
Password => $db_pass,
ShowErrorStatement => 1, ShowErrorStatement => 1,
HandleError => \&_handle_error, HandleError => \&_handle_error,
FetchHashKeyName => 'NAME_lc', FetchHashKeyName => 'NAME_lc',
......
checksetup.pl
View file @ dbce51e8
...@@ -246,7 +246,7 @@ my $modules = [ ...@@ -246,7 +246,7 @@ my $modules = [
}, },
{ {
name => 'DBI', name => 'DBI',
version => '1.32' version => '1.36'
}, },
{ {
name => 'DBD::mysql', name => 'DBD::mysql',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment