Commit f2545f51 authored by endico%mozilla.org's avatar endico%mozilla.org

change '@::legal_resolution_no_dup' to '@::settable_resolutions'. This a list of…

change '@::legal_resolution_no_dup' to '@::settable_resolutions'. This a list of resolutions which a bug may be changed to in the bug form and consists of all legal resolutions except 'MOVED' and 'DUPLICATE', since setting a bug to those resolutions requires a special process.
parent 204f658b
...@@ -39,7 +39,7 @@ sub bug_form_pl_sillyness { ...@@ -39,7 +39,7 @@ sub bug_form_pl_sillyness {
$zz = @::legal_platform; $zz = @::legal_platform;
$zz = @::legal_product; $zz = @::legal_product;
$zz = @::legal_priority; $zz = @::legal_priority;
$zz = @::legal_resolution_no_dup; $zz = @::settable_resolution;
$zz = @::legal_severity; $zz = @::legal_severity;
$zz = %::target_milestone; $zz = %::target_milestone;
} }
...@@ -140,7 +140,7 @@ GetVersionTable(); ...@@ -140,7 +140,7 @@ GetVersionTable();
# These should be read from the database ... # These should be read from the database ...
# #
my $resolution_popup = make_options(\@::legal_resolution_no_dup, my $resolution_popup = make_options(\@::settable_resolution,
$bug{'resolution'}); $bug{'resolution'});
my $platform_popup = make_options(\@::legal_platform, $bug{'rep_platform'}); my $platform_popup = make_options(\@::legal_platform, $bug{'rep_platform'});
my $priority_popup = make_options(\@::legal_priority, $bug{'priority'}); my $priority_popup = make_options(\@::legal_priority, $bug{'priority'});
......
...@@ -40,7 +40,7 @@ sub sillyness { ...@@ -40,7 +40,7 @@ sub sillyness {
$zz = @::legal_platform; $zz = @::legal_platform;
$zz = @::legal_priority; $zz = @::legal_priority;
$zz = @::legal_product; $zz = @::legal_product;
$zz = @::legal_resolution_no_dup; $zz = @::settable_resolution;
$zz = @::legal_severity; $zz = @::legal_severity;
$zz = @::versions; $zz = @::versions;
$zz = @::target_milestone; $zz = @::target_milestone;
...@@ -1217,7 +1217,8 @@ function SetCheckboxes(value) { ...@@ -1217,7 +1217,8 @@ function SetCheckboxes(value) {
} }
document.write(\" <input type=button value=\\\"Uncheck All\\\" onclick=\\\"SetCheckboxes(false);\\\"> <input type=button value=\\\"Check All\\\" onclick=\\\"SetCheckboxes(true);\\\">\"); document.write(\" <input type=button value=\\\"Uncheck All\\\" onclick=\\\"SetCheckboxes(false);\\\"> <input type=button value=\\\"Check All\\\" onclick=\\\"SetCheckboxes(true);\\\">\");
</SCRIPT>"; </SCRIPT>";
my $resolution_popup = make_options(\@::legal_resolution_no_dup, "FIXED");
my $resolution_popup = make_options(\@::settable_resolution, "FIXED");
my @prod_list = keys %prodhash; my @prod_list = keys %prodhash;
my @list = @prod_list; my @list = @prod_list;
my @legal_versions; my @legal_versions;
......
...@@ -412,10 +412,20 @@ sub GenerateVersionTable { ...@@ -412,10 +412,20 @@ sub GenerateVersionTable {
@::legal_opsys = SplitEnumType($cols->{"op_sys,type"}); @::legal_opsys = SplitEnumType($cols->{"op_sys,type"});
@::legal_bug_status = SplitEnumType($cols->{"bug_status,type"}); @::legal_bug_status = SplitEnumType($cols->{"bug_status,type"});
@::legal_resolution = SplitEnumType($cols->{"resolution,type"}); @::legal_resolution = SplitEnumType($cols->{"resolution,type"});
@::legal_resolution_no_dup = @::legal_resolution;
my $w = lsearch(\@::legal_resolution_no_dup, "DUPLICATE"); # 'settable_resolution' is the list of resolutions that may be set
# directly by hand in the bug form. Start with the list of legal
# resolutions and remove 'MOVED' and 'DUPLICATE' because setting
# bugs to those resolutions requires a special process.
#
@::settable_resolution = @::legal_resolution;
my $w = lsearch(\@::settable_resolution, "DUPLICATE");
if ($w >= 0) { if ($w >= 0) {
splice(@::legal_resolution_no_dup, $w, 1); splice(@::settable_resolution, $w, 1);
}
my $z = lsearch(\@::settable_resolution, "MOVED");
if ($z >= 0) {
splice(@::settable_resolution, $z, 1);
} }
my @list = sort { uc($a) cmp uc($b)} keys(%::versions); my @list = sort { uc($a) cmp uc($b)} keys(%::versions);
...@@ -439,9 +449,10 @@ sub GenerateVersionTable { ...@@ -439,9 +449,10 @@ sub GenerateVersionTable {
@::legal_components = sort {uc($a) cmp uc($b)} keys(%carray); @::legal_components = sort {uc($a) cmp uc($b)} keys(%carray);
print FID GenerateCode('@::legal_components'); print FID GenerateCode('@::legal_components');
foreach my $i('product', 'priority', 'severity', 'platform', 'opsys', foreach my $i('product', 'priority', 'severity', 'platform', 'opsys',
'bug_status', 'resolution', 'resolution_no_dup') { 'bug_status', 'resolution') {
print FID GenerateCode('@::legal_' . $i); print FID GenerateCode('@::legal_' . $i);
} }
print FID GenerateCode('@::settable_resolution');
print FID GenerateCode('%::proddesc'); print FID GenerateCode('%::proddesc');
print FID GenerateCode('%::prodmaxvotes'); print FID GenerateCode('%::prodmaxvotes');
print FID GenerateCode('$::anyvotesallowed'); print FID GenerateCode('$::anyvotesallowed');
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment