fix check_log: enable log verification again

share/eterbuild/functions/check

 #!/bin/bash
-# 2008, 2011 Etersoft www.etersoft.ru
+# 2008, 2011, 2013 Etersoft www.etersoft.ru
 # Author: Vitaly Lipatov <lav@etersoft.ru>
 # Public domain
 
 
+__check_string()
+{
+	local LOGFILE="$1"
+	shift
+	local NC="$@"
+	grep -- "$NC" $LOGFILE && warning "'$NC' problem exists in the build output"
+}
+
 check_log()
 {
 	local LOGFILE i RES
 	echo
 	echo "-------------------------------------------------------"
-	echog "Check log for..."
 	LOGFILE=$1
-	
+	echog "Check log $LOGFILE for..."
+
+	# obsoleted
 	if grep -q 'ld: warning: libstdc++\.so\.5, needed by [^ ]\+, may conflict with libstdc++\.so\.6' $LOGFILE ; then
 		echog "Error found: libstdc++.so.5/6 conflicts. Check the log."
 		return 1
@@ -21,18 +30,14 @@ check_log()
 		echog "Error found: will always overflow destination buffer. Check the log."
 		return 1
 	fi
-	
-	#grep "WARNING:" $LOGFILE
 
-	grep 'python-strict' $LOGFILE && warning "python-strict used!!!"
-	NC1="command not found"
-	NC2="-march=athlon -mtune=athlon-xp"
-	NC3="WARNING:"
-	#for i in ${NC1} ; do
-	grep -- '$NC1' $LOGFILE && warning "'$NC1' in build output (some errors in a scripts)"
-	grep -- '$NC2' $LOGFILE && warning "'$NC2' in build output (forbidden) "
-	grep -- '$NC3' $LOGFILE && warning "'$NC3' in build output (forbidden) "
-	#done
+	local i
+	for i in	"python-strict" \
+			"command not found" \
+			"-march=athlon -mtune=athlon-xp" \
+			"WARNING:"; do
+		__check_string $LOGFILE "$i"
+	done
+
 	return 0
 }
-

tests/test_check_log.sh

+#!/bin/sh
+
+# Run with rpm build log for test
+
+. `dirname $0`/../share/eterbuild/functions/common
+load_mod check
+
+check_log $1