Fix select/unselect API for path

102c9ab1 · Masayuki Tanaka · 1bdc159f · 102c9ab1 · 102c9ab1
Commit 102c9ab1 authored May 10, 2014 by Masayuki Tanaka
Expand all Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 2 deletions

c3.js c3.js +8 -2

c3.min.js c3.min.js +0 -0

No files found.
--- a/c3.js
+++ b/c3.js
@@ -4257,7 +4257,10 @@
                    isTargetId = __data_selection_grouped || !ids || ids.indexOf(id) >= 0,
                    isTargetIndex = !indices || indices.indexOf(i) >= 0,
                    isSelected = shape.classed(CLASS.SELECTED);
-                if (this.nodeName === 'path') { return; } // path selection not supported yet
+                // line/area selection not supported yet
+                if (shape.classed(CLASS.line) || shape.classed(CLASS.area)) {
+                    return;
+                }
                if (isTargetId && isTargetIndex) {
                    if (__data_selection_isselectable(d) && !isSelected) {
                        toggle(true, shape.classed(CLASS.SELECTED, true), d, i);
@@ -4277,7 +4280,10 @@
                    isTargetId = __data_selection_grouped || !ids || ids.indexOf(id) >= 0,
                    isTargetIndex = !indices || indices.indexOf(i) >= 0,
                    isSelected = shape.classed(CLASS.SELECTED);
-                if (this.nodeName === 'path') { return; } // path selection not supported yet
+                // line/area selection not supported yet
+                if (shape.classed(CLASS.line) || shape.classed(CLASS.area)) {
+                    return;
+                }
                if (isTargetId && isTargetIndex) {
                    if (__data_selection_isselectable(d)) {
                        if (isSelected) {

--- a/c3.min.js
+++ b/c3.min.js