Commit b9342ab1 authored by Masayuki Tanaka's avatar Masayuki Tanaka

Revert legend item hidden style because of flicker

parent 0fd30419
...@@ -115,9 +115,6 @@ ...@@ -115,9 +115,6 @@
.c3-legend-item { .c3-legend-item {
font-size: 12px; font-size: 12px;
} }
.c3-legend-item-hidden {
opacity: 0.1;
}
/*-- Tooltip --*/ /*-- Tooltip --*/
......
...@@ -3744,16 +3744,14 @@ ...@@ -3744,16 +3744,14 @@
/*-- Draw Legend --*/ /*-- Draw Legend --*/
function opacityForLegend(id) { function opacityForLegend(id) {
var item = legend.select(selectorLegend(id)); return d3.select(selectorLegend(id)).classed(CLASS.legendItemHidden) ? 0.5 : 1;
item.style('opacity', null); // MEMO: remove to get opacity by css
return item.classed(CLASS.legendItemHidden) ? item.style('opacity') : 1;
} }
function toggleFocusLegend(id, focus) { function toggleFocusLegend(id, focus) {
var items = legend.selectAll('.' + CLASS.legendItem).filter(function () { return !d3.select(this).classed(CLASS.legendItemHidden); }), var legendItem = legend.selectAll('.' + CLASS.legendItem),
isTarget = function (d) { return (!id || d === id); }, isTarget = function (d) { return (!id || d === id); },
notTarget = function (d) { return !isTarget(d); }; notTarget = function (d) { return !isTarget(d); };
items.filter(notTarget).transition().duration(100).style('opacity', focus ? 0.3 : opacityForLegend); legendItem.filter(notTarget).transition().duration(100).style('opacity', focus ? 0.3 : opacityForLegend);
items.filter(isTarget).transition().duration(100).style('opacity', focus ? opacityForLegend : 0.3); legendItem.filter(isTarget).transition().duration(100).style('opacity', focus ? opacityForLegend : 0.3);
} }
function focusLegend(id) { function focusLegend(id) {
toggleFocusLegend(id, true); toggleFocusLegend(id, true);
...@@ -4023,7 +4021,9 @@ ...@@ -4023,7 +4021,9 @@
showLegend(targetIds); showLegend(targetIds);
} else { } else {
legend.selectAll(selectorLegends(targetIds)) legend.selectAll(selectorLegends(targetIds))
.classed(CLASS.legendItemHidden, false); .classed(CLASS.legendItemHidden, false)
.transition()
.style('opacity', 1);
} }
redraw({withUpdateOrgXDomain: true, withUpdateXDomain: true, withTransitionForHorizontalAxis: false}); redraw({withUpdateOrgXDomain: true, withUpdateXDomain: true, withTransitionForHorizontalAxis: false});
...@@ -4042,7 +4042,9 @@ ...@@ -4042,7 +4042,9 @@
hideLegend(targetIds); hideLegend(targetIds);
} else { } else {
legend.selectAll(selectorLegends(targetIds)) legend.selectAll(selectorLegends(targetIds))
.classed(CLASS.legendItemHidden, true); .classed(CLASS.legendItemHidden, true)
.transition()
.style('opacity', 0.5);
} }
redraw({withUpdateOrgXDomain: true, withUpdateXDomain: true, withTransitionForHorizontalAxis: false}); redraw({withUpdateOrgXDomain: true, withUpdateXDomain: true, withTransitionForHorizontalAxis: false});
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment