Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
C
c3-closed
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Evgeny
c3-closed
Commits
fbe6e4c7
Commit
fbe6e4c7
authored
Apr 11, 2015
by
Richard Knoll
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fixed resize event removal and performance issue while resizing
parent
e83d0e78
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
74 additions
and
15 deletions
+74
-15
api.chart.js
src/api.chart.js
+16
-1
config.js
src/config.js
+2
-0
core.js
src/core.js
+56
-14
No files found.
src/api.chart.js
View file @
fbe6e4c7
...
...
@@ -14,7 +14,22 @@ c3_chart_fn.destroy = function () {
var
$$
=
this
.
internal
;
window
.
clearInterval
(
$$
.
intervalForObserveInserted
);
window
.
onresize
=
null
;
if
(
$$
.
resizeTimeout
!==
undefined
)
{
window
.
clearTimeout
(
$$
.
resizeTimeout
);
}
if
(
window
.
detachEvent
)
{
window
.
detachEvent
(
'onresize'
,
$$
.
resizeFunction
);
}
else
if
(
window
.
removeEventListener
)
{
window
.
removeEventListener
(
'resize'
,
$$
.
resizeFunction
);
}
else
{
var
wrapper
=
window
.
onresize
;
// check if no one else removed our wrapper and remove our resizeFunction from it
if
(
wrapper
&&
wrapper
.
add
&&
wrapper
.
remove
)
{
wrapper
.
remove
(
$$
.
resizeFunction
);
}
}
$$
.
selectChart
.
classed
(
'c3'
,
false
).
html
(
""
);
...
...
src/config.js
View file @
fbe6e4c7
...
...
@@ -7,6 +7,8 @@ c3_chart_internal_fn.getDefaultConfig = function () {
padding_right
:
undefined
,
padding_top
:
undefined
,
padding_bottom
:
undefined
,
resize_auto
:
true
,
resize_timeout
:
100
,
zoom_enabled
:
false
,
zoom_extent
:
undefined
,
zoom_privileged
:
false
,
...
...
src/core.js
View file @
fbe6e4c7
...
...
@@ -319,20 +319,7 @@ c3_chart_internal_fn.initWithData = function (data) {
}
// Bind resize event
if
(
window
.
onresize
==
null
)
{
window
.
onresize
=
$$
.
generateResize
();
}
if
(
window
.
onresize
.
add
)
{
window
.
onresize
.
add
(
function
()
{
config
.
onresize
.
call
(
$$
);
});
window
.
onresize
.
add
(
function
()
{
$$
.
api
.
flush
();
});
window
.
onresize
.
add
(
function
()
{
config
.
onresized
.
call
(
$$
);
});
}
$$
.
bindResize
();
// export element of the chart
$$
.
api
.
element
=
$$
.
selectChart
.
node
();
...
...
@@ -927,6 +914,53 @@ c3_chart_internal_fn.observeInserted = function (selection) {
observer
.
observe
(
selection
.
node
(),
{
attributes
:
true
,
childList
:
true
,
characterData
:
true
});
};
c3_chart_internal_fn
.
bindResize
=
function
()
{
var
$$
=
this
,
config
=
$$
.
config
;
$$
.
resizeFunction
=
$$
.
generateResize
();
$$
.
resizeFunction
.
add
(
function
()
{
config
.
onresize
.
call
(
$$
);
});
if
(
config
.
resize_auto
)
{
$$
.
resizeFunction
.
add
(
function
()
{
if
(
config
.
resize_timeout
)
{
if
(
$$
.
resizeTimeout
!==
undefined
)
{
window
.
clearTimeout
(
$$
.
resizeTimeout
);
}
$$
.
resizeTimeout
=
window
.
setTimeout
(
function
()
{
delete
$$
.
resizeTimeout
;
$$
.
api
.
flush
();
},
config
.
resize_timeout
);
}
else
{
$$
.
api
.
flush
();
}
});
}
$$
.
resizeFunction
.
add
(
function
()
{
config
.
onresized
.
call
(
$$
);
});
if
(
window
.
attachEvent
)
{
window
.
attachEvent
(
'onresize'
,
$$
.
resizeFunction
);
}
else
if
(
window
.
addEventListener
)
{
window
.
addEventListener
(
'resize'
,
$$
.
resizeFunction
,
false
);
}
else
{
// fallback to this, if this is a very old browser
var
wrapper
=
window
.
onresize
;
if
(
!
wrapper
)
{
// create a wrapper that will call all charts
wrapper
=
$$
.
generateResize
();
}
else
if
(
!
wrapper
.
add
||
!
wrapper
.
remove
)
{
// there is already a handler registered, make sure we call it too
wrapper
=
$$
.
generateResize
();
wrapper
.
add
(
window
.
onresize
);
}
// add this graph to the wrapper, we will be removed if the user calls destroy
wrapper
.
add
(
$$
.
resizeFunction
);
window
.
onresize
=
wrapper
;
}
};
c3_chart_internal_fn
.
generateResize
=
function
()
{
var
resizeFunctions
=
[];
...
...
@@ -938,6 +972,14 @@ c3_chart_internal_fn.generateResize = function () {
callResizeFunctions
.
add
=
function
(
f
)
{
resizeFunctions
.
push
(
f
);
};
callResizeFunctions
.
remove
=
function
(
f
)
{
for
(
var
i
=
0
;
i
<
resizeFunctions
.
length
;
i
++
)
{
if
(
resizeFunctions
[
i
]
===
f
)
{
resizeFunctions
.
splice
(
i
,
1
);
break
;
}
}
};
return
callResizeFunctions
;
};
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment