pcm_buffer: poison the old buffer before returning it

Make valgrind find more buffer misuses. Buffer contents are not persistent, they get invalidated by pcm_buffer_get(), because this function may allocate a new buffer, but will not copy old data.

pcm_buffer: poison the old buffer before returning it
006b8fa3 · Max Kellermann · 6a01153c · 006b8fa3
Commit 006b8fa3 authored Nov 28, 2011 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

pcm_buffer.c src/pcm_buffer.c +4 -0

No files found.
--- a/src/pcm_buffer.c
+++ b/src/pcm_buffer.c
@@ -19,6 +19,7 @@

 #include "config.h"
 #include "pcm_buffer.h"
+#include "poison.h"

 /**
 * Align the specified size to the next 8k boundary.
@@ -41,6 +42,9 @@ pcm_buffer_get(struct pcm_buffer *buffer, size_t size)

 		buffer->size = align_8k(size);
 		buffer->buffer = g_malloc(buffer->size);
+	} else {
+		/* discard old buffer contents */
+		poison_undefined(buffer->buffer, buffer->size);
 	}

 	assert(buffer->size >= size);