playlist/flac: copy the URI to fix use-after-free bug

Closes https://github.com/MusicPlayerDaemon/MPD/issues/508

playlist/flac: copy the URI to fix use-after-free bug
0d986772 · Max Kellermann · 38f0c169 · 0d986772 · 0d986772
Commit 0d986772 authored Mar 14, 2019 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

NEWS NEWS +2 -0

FlacPlaylistPlugin.cxx src/playlist/plugins/FlacPlaylistPlugin.cxx +1 -1

No files found.
--- a/NEWS
+++ b/NEWS
@@ -3,6 +3,8 @@ ver 0.21.6 (not yet released)
  - allow loading playlists specified as absolute filesystem paths
 * input
  - cdio_paranoia: fix build failure due to missing #include
+* playlist
+  - flac: fix use-after-free bug
 * support abstract sockets on Linux

 ver 0.21.5 (2019/02/22)

--- a/src/playlist/plugins/FlacPlaylistPlugin.cxx
+++ b/src/playlist/plugins/FlacPlaylistPlugin.cxx
@@ -34,7 +34,7 @@
 #include <FLAC/metadata.h>

 class FlacPlaylist final : public SongEnumerator {
-	const char *const uri;
+	const std::string uri;

 	FLAC__StreamMetadata *const cuesheet;
 	const unsigned sample_rate;