song_save: check for colon and space when loading a tag

matchesAnMpdTagItemKey() broke when two tag items had the same prefix, because it did not check if the tag name ended after the prefix. Add a check for the colon and the space after the tag name.

song_save: check for colon and space when loading a tag
14527174 · Max Kellermann · 45598d50 · 14527174
Commit 14527174 authored Jan 13, 2009 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

song_save.c src/song_save.c +4 -2

No files found.
--- a/src/song_save.c
+++ b/src/song_save.c
@@ -91,8 +91,10 @@ static int matchesAnMpdTagItemKey(char *buffer, int *itemType)
 	int i;

 	for (i = 0; i < TAG_NUM_OF_ITEM_TYPES; i++) {
-		if (0 == strncmp(mpdTagItemKeys[i], buffer,
-				 strlen(mpdTagItemKeys[i]))) {
+		size_t len = strlen(mpdTagItemKeys[i]);
+
+		if (0 == strncmp(mpdTagItemKeys[i], buffer, len) &&
+		    buffer[len] == ':' && buffer[len + 1] == ' ') {
 			*itemType = i;
 			return 1;
 		}