Skip to content

M
mpd
Commit 18cb4fa2 authored by Max Kellermann's avatar Max Kellermann
Browse files
Options

output_all: check param!=NULL before accessing it

When printing the error message, MPD dereferences the NULL pointer to print an error message if no audio_output section is present.
parent f35432af
Hide whitespace changes
Inline Side-by-side
Showing with 7 additions and 2 deletions
src/output_all.c
View file @ 18cb4fa2
......@@ -113,8 +113,13 @@ audio_output_all_init(void)
/* only allow param to be NULL if there just one audioOutput */
assert(param || (num_audio_outputs == 1));
if (!audio_output_init(output, param, &error))
g_error("line %i: %s", param->line, error->message);
if (!audio_output_init(output, param, &error)) {
if (param != NULL)
g_error("line %i: %s",
param->line, error->message);
else
g_error("%s", error->message);
}
/* require output names to be unique: */
for (j = 0; j < i; j++) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment