output/alsa: throw on snd_pcm_writei() error while draining

This implements real error handling, and avoids calling CancelInternal() from this code path.

output/alsa: throw on snd_pcm_writei() error while draining
1a43f514 · Max Kellermann · 7f143a83 · 1a43f514
Commit 1a43f514 authored Nov 14, 2018 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 3 deletions

AlsaOutputPlugin.cxx src/output/plugins/AlsaOutputPlugin.cxx +6 -3

No files found.
--- a/src/output/plugins/AlsaOutputPlugin.cxx
+++ b/src/output/plugins/AlsaOutputPlugin.cxx
@@ -727,9 +727,12 @@ AlsaOutput::DrainInternal()
 	/* drain period_buffer */
 	if (!period_buffer.IsEmpty()) {
 		auto frames_written = WriteFromPeriodBuffer();
-		if (frames_written < 0 && frames_written != -EAGAIN) {
-			CancelInternal();
-			return true;
+		if (frames_written < 0) {
+			if (frames_written == -EAGAIN)
+				return false;
+
+			throw FormatRuntimeError("snd_pcm_writei() failed: %s",
+						 snd_strerror(-frames_written));
 		}

 		if (!period_buffer.IsEmpty())