output_all: fix boolean short circuit in update()

Sometimes, audio_output_update() isn't called for the second device when the first one has succeeded. The patch "audio_output_all_update() returns bool" broke it, because the boolean evaluation ended after the first "true".

output_all: fix boolean short circuit in update()
27193d84 · Max Kellermann · fc6d836a · 27193d84
Commit 27193d84 authored Mar 07, 2009 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

output_all.c src/output_all.c +2 -2

No files found.
--- a/src/output_all.c
+++ b/src/output_all.c
@@ -178,8 +178,8 @@ audio_output_all_update(void)
 		return false;

 	for (i = 0; i < num_audio_outputs; ++i)
-		ret = ret || audio_output_update(&audio_outputs[i],
-						 &input_audio_format);
+		ret = audio_output_update(&audio_outputs[i],
+					  &input_audio_format) || ret;

 	return ret;
 }