Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
M
mpd
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Иван Мажукин
mpd
Commits
27e46565
Commit
27e46565
authored
7 years ago
by
Max Kellermann
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
input/{file,archive}: remove the dummy InputPlugin instances
These have no use, exception for creating an artificial dependency from input_plugins[] to all archive plugins.
parent
e0a09dbd
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
6 additions
and
46 deletions
+6
-46
CommandLine.cxx
src/CommandLine.cxx
+6
-1
Registry.cxx
src/input/Registry.cxx
+0
-9
ArchiveInputPlugin.cxx
src/input/plugins/ArchiveInputPlugin.cxx
+0
-16
ArchiveInputPlugin.hxx
src/input/plugins/ArchiveInputPlugin.hxx
+0
-2
FileInputPlugin.cxx
src/input/plugins/FileInputPlugin.cxx
+0
-16
FileInputPlugin.hxx
src/input/plugins/FileInputPlugin.hxx
+0
-2
No files found.
src/CommandLine.cxx
View file @
27e46565
...
...
@@ -200,7 +200,12 @@ static void version(void)
#endif
"
\n
"
"Input plugins:
\n
"
);
"Input plugins:
\n
"
" file"
#ifdef ENABLE_ARCHIVE
" archive"
#endif
);
input_plugins_for_each
(
plugin
)
printf
(
" %s"
,
plugin
->
name
);
...
...
This diff is collapsed.
Click to expand it.
src/input/Registry.cxx
View file @
27e46565
...
...
@@ -20,7 +20,6 @@
#include "config.h"
#include "Registry.hxx"
#include "util/Macros.hxx"
#include "plugins/FileInputPlugin.hxx"
#include "plugins/TidalInputPlugin.hxx"
#include "plugins/QobuzInputPlugin.hxx"
...
...
@@ -28,10 +27,6 @@
#include "plugins/AlsaInputPlugin.hxx"
#endif
#ifdef ENABLE_ARCHIVE
#include "plugins/ArchiveInputPlugin.hxx"
#endif
#ifdef ENABLE_CURL
#include "plugins/CurlInputPlugin.hxx"
#endif
...
...
@@ -57,13 +52,9 @@
#endif
const
InputPlugin
*
const
input_plugins
[]
=
{
&
input_plugin_file
,
#ifdef ENABLE_ALSA
&
input_plugin_alsa
,
#endif
#ifdef ENABLE_ARCHIVE
&
input_plugin_archive
,
#endif
#ifdef ENABLE_TIDAL
&
tidal_input_plugin
,
#endif
...
...
This diff is collapsed.
Click to expand it.
src/input/plugins/ArchiveInputPlugin.cxx
View file @
27e46565
...
...
@@ -63,19 +63,3 @@ OpenArchiveInputStream(Path path, Mutex &mutex, Cond &cond)
return
archive_file_open
(
arplug
,
Path
::
FromFS
(
archive
))
->
OpenStream
(
filename
,
mutex
,
cond
);
}
static
InputStreamPtr
input_archive_open
(
gcc_unused
const
char
*
filename
,
gcc_unused
Mutex
&
mutex
,
gcc_unused
Cond
&
cond
)
{
/* dummy method; use OpenArchiveInputStream() instead */
return
nullptr
;
}
const
InputPlugin
input_plugin_archive
=
{
"archive"
,
nullptr
,
nullptr
,
input_archive_open
,
};
This diff is collapsed.
Click to expand it.
src/input/plugins/ArchiveInputPlugin.hxx
View file @
27e46565
...
...
@@ -26,8 +26,6 @@ class Path;
class
Mutex
;
class
Cond
;
extern
const
struct
InputPlugin
input_plugin_archive
;
InputStreamPtr
OpenArchiveInputStream
(
Path
path
,
Mutex
&
mutex
,
Cond
&
cond
);
...
...
This diff is collapsed.
Click to expand it.
src/input/plugins/FileInputPlugin.cxx
View file @
27e46565
...
...
@@ -75,15 +75,6 @@ OpenFileInputStream(Path path,
mutex
,
cond
);
}
static
InputStreamPtr
input_file_open
(
gcc_unused
const
char
*
filename
,
gcc_unused
Mutex
&
mutex
,
gcc_unused
Cond
&
cond
)
{
/* dummy method; use OpenFileInputStream() instead */
return
nullptr
;
}
void
FileInputStream
::
Seek
(
offset_type
new_offset
)
{
...
...
@@ -108,10 +99,3 @@ FileInputStream::Read(void *ptr, size_t read_size)
offset
+=
nbytes
;
return
nbytes
;
}
const
InputPlugin
input_plugin_file
=
{
"file"
,
nullptr
,
nullptr
,
input_file_open
,
};
This diff is collapsed.
Click to expand it.
src/input/plugins/FileInputPlugin.hxx
View file @
27e46565
...
...
@@ -26,8 +26,6 @@ class Path;
class
Mutex
;
class
Cond
;
extern
const
struct
InputPlugin
input_plugin_file
;
InputStreamPtr
OpenFileInputStream
(
Path
path
,
Mutex
&
mutex
,
Cond
&
cond
);
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment