yet more unsigned integers

calculateCrossFadeChunks() still returns int, although the caller uses it as an unsigned value. Since the function body checks for negative values, it is safe to cast to unsigned. crossFade() takes signed parameters, although it callers pass unsigned integers. Change declaration to unsigned. git-svn-id: https://svn.musicpd.org/mpd/trunk@7291 09075e82-0dd4-0310-85a5-a0d7c8717e4f

yet more unsigned integers
2bd2957a · Max Kellermann · Eric Wong · f7e97c9a · 2bd2957a
Commit 2bd2957a authored Apr 12, 2008 by Max Kellermann Committed by Eric Wong Apr 12, 2008
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 4 deletions

decode.c src/decode.c +4 -4

No files found.
--- a/src/decode.c
+++ b/src/decode.c
@@ -76,8 +76,8 @@ static void quitDecode(PlayerControl * pc, DecoderControl * dc)
 	wakeup_main_task();
 }

-static int calculateCrossFadeChunks(PlayerControl * pc, AudioFormat * af,
-				    float totalTime)
+static unsigned calculateCrossFadeChunks(PlayerControl * pc, AudioFormat * af,
+					 float totalTime)
 {
 	long chunks;

@@ -95,7 +95,7 @@ static int calculateCrossFadeChunks(PlayerControl * pc, AudioFormat * af,
 	if (chunks < 0)
 		chunks = 0;

-	return (int)chunks;
+	return (unsigned)chunks;
 }

 static int waitOnDecode(PlayerControl * pc, DecoderControl * dc,
@@ -365,7 +365,7 @@ static void advanceOutputBufferTo(OutputBuffer * cb, int to)

 static void crossFade(OutputBufferChunk * a, OutputBufferChunk * b,
 		      AudioFormat * format,
-		      int fadePosition, int crossFadeChunks)
+		      unsigned int fadePosition, unsigned int crossFadeChunks)
 {
 	pcm_mix(a->data,
 		b->data,