playlist: safely search the playlist for deleted song

When a song file is deleted during database update, all pointers to it must be removed from the playlist. The "for" loop in deleteASongFromPlaylist() did not deal with multiple copies of the deleted song properly, and left instances of the (to-be-invalidated) pointer in. Fix this by reversing the loop.

playlist: safely search the playlist for deleted song
2c540ee8 · Max Kellermann · 2af1742f · 2c540ee8 · 2c540ee8
Commit 2c540ee8 authored Jan 14, 2009 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 1 deletion

NEWS NEWS +7 -0

playlist.c src/playlist.c +1 -1

No files found.
--- a/NEWS
+++ b/NEWS
@@ -15,6 +15,13 @@ ver 0.15 - (200?/??/??)
 * fix cross-fading bug: it used to play some chunks of the new song twice
 * --create-db starts the MPD daemon instead of exiting
 * input_curl: honour http_proxy_* config directives
+* playlist
+  - fix assertion failure during playlist load
+  - implement Fisher-Yates shuffle properly
+  - safely search the playlist for deleted song
+* use custom PRNG for volume dithering (speedup)
+* detect libid3tag without pkg-config
 ver 0.14 (2008/12/25)
 * audio outputs:

--- a/src/playlist.c
+++ b/src/playlist.c
@@ -764,7 +764,7 @@ deleteASongFromPlaylist(const struct song *song)
 	if (NULL == playlist.songs)
 		return;
-	for (unsigned i = 0; i < playlist.length; i++)
+	for (int i = playlist.length - 1; i >= 0; --i)
 		if (song == playlist.songs[i])
 			deleteFromPlaylist(i);