log: don't manipulate the umask

If the user wants the log files with a specific mode, he has to start MPD with the correct umask. Don't hard-code that. This fixes a bug: when log cycling failed, MPD would not restore the old umask.

log: don't manipulate the umask
2c5885e9 · Max Kellermann · 8e9def1b · 2c5885e9
Commit 2c5885e9 authored Dec 28, 2008 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 9 deletions

log.c src/log.c +1 -9

No files found.
--- a/src/log.c
+++ b/src/log.c
@@ -96,17 +96,9 @@ mpd_log_func(const gchar *log_domain,
 static int
 open_log_file(void)
 {
-	mode_t prev;
-	int fd;
-
 	assert(out_filename != NULL);

-	prev = umask(0066);
-	fd = open(out_filename, O_CREAT | O_WRONLY | O_APPEND, 0666);
-
-	umask(prev);
-
-	return fd;
+	return open(out_filename, O_CREAT | O_WRONLY | O_APPEND, 0666);
 }

 void initLog(bool verbose)