player/Thread: call OnPlayerSync() in SeekDecoder()

This fixes a spurious "single" mode bug which occurs when using "play" or "seek" to start playback on the song that is currently paused: in that case, the main thread never queues the next song, and at the end of the song, the player thread exits Run(), stopping playback, and after that, the main thread starts the next song without considering "single" mode. By calling OnPlayerSync(), we ensure that the main thread gets a chance to queue the next song before the player thread exits the Run() loop. Closes https://github.com/MusicPlayerDaemon/MPD/issues/850

player/Thread: call OnPlayerSync() in SeekDecoder()
32f4f158 · Max Kellermann · e29c06b7 · 32f4f158 · 32f4f158
Commit 32f4f158 authored Sep 16, 2020 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 0 deletions

NEWS NEWS +1 -0

Thread.cxx src/player/Thread.cxx +6 -0

No files found.
--- a/NEWS
+++ b/NEWS
@@ -12,6 +12,7 @@ ver 0.21.26 (not yet released)
  - ffmpeg: remove "rtsp://" from the list of supported protocols
  - ffmpeg: add "hls+http://" to the list of supported protocols
  - sndfile: fix lost samples at end of file
+* fix "single" mode bug after resuming playback
 * the default log_level is "default", not "info"

 ver 0.21.25 (2020/07/06)

--- a/src/player/Thread.cxx
+++ b/src/player/Thread.cxx
@@ -681,6 +681,12 @@ Player::SeekDecoder() noexcept
 	/* re-fill the buffer after seeking */
 	buffering = true;

+	{
+		/* call syncPlaylistWithQueue() in the main thread */
+		const ScopeUnlock unlock(pc.mutex);
+		pc.listener.OnPlayerSync();
+	}
+
 	return true;
 }