pulse_mixer: unlock the mainloop on failure

It's illegal to return from pulse_mixer_setup() without unlocking the main loop. In the error handling, that unlock() call was missing.

pulse_mixer: unlock the mainloop on failure
3d2c8b00 · Max Kellermann · d113c071 · 3d2c8b00
Commit 3d2c8b00 authored Mar 26, 2009 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 0 deletions

pulse_mixer.c src/mixer/pulse_mixer.c +2 -0

No files found.
--- a/src/mixer/pulse_mixer.c
+++ b/src/mixer/pulse_mixer.c
@@ -205,6 +205,7 @@ pulse_mixer_setup(struct pulse_mixer *pm)
 	pa_threaded_mainloop_lock(pm->mainloop);

 	if (pa_threaded_mainloop_start(pm->mainloop) < 0) {
+		pa_threaded_mainloop_unlock(pm->mainloop);
 		g_debug("error start mainloop");
 		return false;
 	}
@@ -212,6 +213,7 @@ pulse_mixer_setup(struct pulse_mixer *pm)
 	pa_threaded_mainloop_wait(pm->mainloop);

 	if (pa_context_get_state(pm->context) != PA_CONTEXT_READY) {
+		pa_threaded_mainloop_unlock(pm->mainloop);
 		g_debug("error context not ready");
 		return false;
 	}