decoder/dsdiff: use a fixed-size buffer for the tag value

Variable-length arrays are a C-only feature.

decoder/dsdiff: use a fixed-size buffer for the tag value
3e40b1d9 · Max Kellermann · adffbba2 · 3e40b1d9
Commit 3e40b1d9 authored Jun 06, 2019 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

DsdiffDecoderPlugin.cxx src/decoder/plugins/DsdiffDecoderPlugin.cxx +3 -2

No files found.
--- a/src/decoder/plugins/DsdiffDecoderPlugin.cxx
+++ b/src/decoder/plugins/DsdiffDecoderPlugin.cxx
@@ -201,10 +201,11 @@ dsdiff_handle_native_tag(InputStream &is,
 	uint32_t length = FromBE32(metatag.size);

 	/* Check and limit size of the tag to prevent a stack overflow */
-	if (length == 0 || length > 60)
+	constexpr size_t MAX_LENGTH = 60;
+	if (length == 0 || length > MAX_LENGTH)
 		return;

-	char string[length + 1];
+	char string[MAX_LENGTH + 1];
 	char *label;
 	label = string;