[OSXOutput] Throw an error when device not found

Currently it falls back to system default device (either internal speaker or headphone) when device not found. I believe it is a better to fail in this case, to make it better aligned with platforms (such as alsa).

[OSXOutput] Throw an error when device not found
42b22187 · Yue Wang · GitHub · cfe22502 · 42b22187
Unverified Commit 42b22187 authored Jan 25, 2019 by Yue Wang Committed by GitHub Jan 25, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 4 deletions

OSXOutputPlugin.cxx src/output/plugins/OSXOutputPlugin.cxx +1 -4

No files found.
--- a/src/output/plugins/OSXOutputPlugin.cxx
+++ b/src/output/plugins/OSXOutputPlugin.cxx
@@ -637,11 +637,8 @@ osx_output_set_device(OSXOutput *oo)
 		}
 	}
 	if (i == numdevices) {
-		FormatWarning(osx_output_domain,
+                throw FormatRuntimeError("Found no audio device with name '%s' ",
-			      "Found no audio device with name '%s' "
-			      "(will use default audio device)",
 			      oo->device_name);
-		return;
 	}
 	status = AudioUnitSetProperty(oo->au,