Skip to content

M
mpd
Commit 42f61771 authored by Max Kellermann's avatar Max Kellermann
Browse files
Options

shout: removed clear_shout_buffer()

The function is trivial, without a benefit. Also don't initialize buf.data[0], this is not a null terminated string.
parent 265b8fff
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 8 deletions
src/audioOutputs/audioOutput_shout.c
View file @ 42f61771
...@@ -45,12 +45,6 @@ shout_encoder_plugin_get(const char *name) ...@@ -45,12 +45,6 @@ shout_encoder_plugin_get(const char *name)
return NULL; return NULL;
} }
static void clear_shout_buffer(struct shout_data * sd)
{
sd->buf.len = 0;
sd->buf.data[0] = '\0';
}
static struct shout_data *new_shout_data(void) static struct shout_data *new_shout_data(void)
{ {
struct shout_data *ret = xmalloc(sizeof(*ret)); struct shout_data *ret = xmalloc(sizeof(*ret));
...@@ -66,7 +60,7 @@ static struct shout_data *new_shout_data(void) ...@@ -66,7 +60,7 @@ static struct shout_data *new_shout_data(void)
ret->conn_attempts = 0; ret->conn_attempts = 0;
ret->last_attempt = 0; ret->last_attempt = 0;
ret->timer = NULL; ret->timer = NULL;
clear_shout_buffer(ret); ret->buf.len = 0;
return ret; return ret;
} }
...@@ -304,7 +298,7 @@ static int write_page(struct shout_data *sd) ...@@ -304,7 +298,7 @@ static int write_page(struct shout_data *sd)
err = shout_send(sd->shout_conn, sd->buf.data, sd->buf.len); err = shout_send(sd->shout_conn, sd->buf.data, sd->buf.len);
if (handle_shout_error(sd, err) < 0) if (handle_shout_error(sd, err) < 0)
return -1; return -1;
clear_shout_buffer(sd); sd->buf.len = 0;
return 0; return 0;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment