Commit 43761441 authored by Eric Wong's avatar Eric Wong Committed by Max Kellermann

song: get rid of newNullSong()

It didn't save us any lines of code nor did it do anything useful since we would overwrite everything anyways.
parent dc245f38
......@@ -28,17 +28,6 @@
#include "os_compat.h"
Song *newNullSong(void)
{
Song *song = xmalloc(sizeof(Song));
song->tag = NULL;
song->url = NULL;
song->type = SONG_TYPE_FILE;
song->parentDir = NULL;
return song;
}
Song *newSong(const char *url, enum song_type type, Directory * parentDir)
{
......@@ -49,8 +38,8 @@ Song *newSong(const char *url, enum song_type type, Directory * parentDir)
return NULL;
}
song = newNullSong();
song = xmalloc(sizeof(*song));
song->tag = NULL;
song->url = xstrdup(url);
song->type = type;
song->parentDir = parentDir;
......
......@@ -42,8 +42,6 @@ typedef struct _Song {
time_t mtime;
} Song;
Song *newNullSong(void);
Song *newSong(const char *url, enum song_type type,
struct _Directory *parentDir);
......
......@@ -111,7 +111,7 @@ void readSongInfoIntoList(FILE *fp, struct songvec *sv,
if (song)
insertSongIntoList(sv, song);
song = newNullSong();
song = xmalloc(sizeof(*song));
song->url = xstrdup(buffer + strlen(SONG_KEY));
song->type = SONG_TYPE_FILE;
song->parentDir = parentDir;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment