don't free client resources except in client_close()

All of the client's resources are freed in client_close(). It is enough to set the "expired" flag, no need to duplicate lots of destruction code again and again.

don't free client resources except in client_close()
4448b17e · Max Kellermann · 61443c13 · 4448b17e
Commit 4448b17e authored Aug 28, 2008 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 15 deletions

client.c src/client.c +0 -15

No files found.
--- a/src/client.c
+++ b/src/client.c
@@ -670,14 +670,6 @@ static void client_write_deferred(struct client *client)
 		/* cause client to close */
 		DEBUG("client %i: problems flushing buffer\n",
 		      client->num);
-		buf = client->deferred_send;
-		do {
-			struct sllnode *prev = buf;
-			buf = buf->next;
-			free(prev);
-		} while (buf);
-		client->deferred_send = NULL;
-		client->deferred_bytes = 0;
 		client->expired = 1;
 	}
 }
@@ -747,13 +739,6 @@ static void client_write_output(struct client *client)
 			      (unsigned long)client_max_output_buffer_size);
 			/* cause client to close */
 			client->expired = 1;
-			do {
-				struct sllnode *prev = buf;
-				buf = buf->next;
-				free(prev);
-			} while (buf);
-			client->deferred_send = NULL;
-			client->deferred_bytes = 0;
 		} else {
 			while (buf->next)
 				buf = buf->next;