Commit 4984639b authored by Max Kellermann's avatar Max Kellermann

input_stream: removed nmemb argument

The nmemb argument isn't actually useful, and one of nmemb and size was always passed as 1. Remove it.
parent b73ecbb0
sisyphus 0.23.15-alt1 0.23.14-alt1 0.23.13-alt1 0.23.12-alt1 0.23.11-alt1 0.23.8-alt3 0.23.8-alt2 0.23.8-alt1 0.21.24-alt1.1 0.21.24-alt1 0.20.23-alt3 0.20.23-alt2 0.20.23-alt1 0.20.21-alt1 0.20.15-alt1 0.18.14-alt1 0.18.11-alt1.1 0.18.11-alt1 0.18.10-alt1 0.17.0-alt0.3.git050212 0.17.0-alt0.2.git200911 0.17.0-alt0.2.M60P.1.git050212 0.17.0-alt0.1 0.16.2-alt2 0.16.2-alt1 0.15.13-alt1 0.15.13-alt0.M51.1 0.15.13-alt 0.15.8-alt2 0.15.8-alt1 0.15.3-alt1.1 0.15.3-alt1 0.15.0-alt2 0.15.0-alt1 0.14.2 0.14.2-alt1 0.14.2-alt 0.14.1 0.14.1-alt 0.14.0-alt 0.14-alt1 0.14-alt v0.18.14 v0.18.13 v0.18.12 v0.18.11 v0.18.10 v0.18.9 v0.18.8 v0.18.7 v0.18.6 v0.18.5 v0.18.4 v0.18.3 v0.18.2 v0.17.3 v0.17.2 v0.17.1 v0.17.0-git200911 v0.17.0-git200711 v0.17.0-git050212 v0.16.8 v0.16.5 v0.16.4 v0.16.3 v0.16.2 v0.16.1 v0.16 v0.16_alpha4 v0.16_alpha3 v0.16_alpha2 v0.15.16 v0.15.14 v0.15.13 v0.15.11 v0.15.10 v0.15.9 v0.15.7 v0.15.6 v0.15.5 release-0.16.5 release-0.16.4 release-0.16.3 release-0.16.1 release-0.16 release-0.16_alpha4 release-0.16_alpha3 release-0.16_alpha2 release-0.15.16 release-0.15.14 release-0.15.13 release-0.15.11 release-0.15.10 release-0.15.9 release-0.15.7 release-0.15.6 release-0.15.5 mpd/0.20.6-alt1 mpd/0.19.9-alt1 mpd/0.18.14-alt2 gb-sisyphus-task339776.6100 gb-sisyphus-task337393.100 gb-sisyphus-task337176.300 gb-sisyphus-task334590.100 gb-sisyphus-task333607.100 gb-sisyphus-task331543.2500 gb-sisyphus-task328663.4700 gb-sisyphus-task325064.100 gb-sisyphus-task319111.4000 gb-sisyphus-task313704.100 gb-sisyphus-task312885.100 gb-sisyphus-task308905.3200 gb-sisyphus-task305294.500 gb-sisyphus-task304007.100 gb-sisyphus-task303674.1700 gb-sisyphus-task298681.300 gb-sisyphus-task296051.1000 gb-sisyphus-task274827.100 gb-sisyphus-task269249.2000 gb-sisyphus-task266579.400 gb-sisyphus-task258132.600 gb-sisyphus-task254601.200 gb-sisyphus-task253310.100 gb-sisyphus-task252214.300 gb-sisyphus-task251539.6100 gb-sisyphus-task247988.7000 gb-sisyphus-task238768.6000 gb-sisyphus-task229151.100 gb-sisyphus-task227574.200 gb-sisyphus-task226762.6000 gb-sisyphus-task219546.1700 gb-sisyphus-task213491.100 gb-sisyphus-task198806.100 gb-sisyphus-task181400.100 gb-sisyphus-task141957.100 gb-sisyphus-task135039.100 gb-sisyphus-task130102.100 gb-sisyphus-task129023.100 gb-sisyphus-task127959.100 gb-sisyphus-task118591.100 gb-p9-task277538.2600 gb-c9f2-task327704.1100 fixed-0.17.0-git200911 alt-0.17.0-git200711 alt-0.17.0-git050212 alt-0.16.2
No related merge requests found
...@@ -115,7 +115,7 @@ size_t decoder_read(struct decoder *decoder, ...@@ -115,7 +115,7 @@ size_t decoder_read(struct decoder *decoder,
dc.command != DECODE_COMMAND_NONE) dc.command != DECODE_COMMAND_NONE)
return 0; return 0;
nbytes = readFromInputStream(inStream, buffer, 1, length); nbytes = readFromInputStream(inStream, buffer, length);
if (nbytes > 0 || inputStreamAtEOF(inStream)) if (nbytes > 0 || inputStreamAtEOF(inStream))
return nbytes; return nbytes;
......
...@@ -71,7 +71,7 @@ static int mp4_getAACTrack(mp4ff_t * infile) ...@@ -71,7 +71,7 @@ static int mp4_getAACTrack(mp4ff_t * infile)
static uint32_t mp4_inputStreamReadCallback(void *inStream, void *buffer, static uint32_t mp4_inputStreamReadCallback(void *inStream, void *buffer,
uint32_t length) uint32_t length)
{ {
return readFromInputStream((InputStream *) inStream, buffer, 1, length); return readFromInputStream((InputStream *) inStream, buffer, length);
} }
static uint32_t mp4_inputStreamSeekCallback(void *inStream, uint64_t position) static uint32_t mp4_inputStreamSeekCallback(void *inStream, uint64_t position)
......
...@@ -54,9 +54,9 @@ int seekInputStream(struct input_stream *inStream, long offset, int whence) ...@@ -54,9 +54,9 @@ int seekInputStream(struct input_stream *inStream, long offset, int whence)
} }
size_t readFromInputStream(struct input_stream *inStream, size_t readFromInputStream(struct input_stream *inStream,
void *ptr, size_t size, size_t nmemb) void *ptr, size_t size)
{ {
return inStream->readFunc(inStream, ptr, size, nmemb); return inStream->readFunc(inStream, ptr, size);
} }
int closeInputStream(struct input_stream *inStream) int closeInputStream(struct input_stream *inStream)
......
...@@ -26,7 +26,7 @@ typedef struct input_stream InputStream; ...@@ -26,7 +26,7 @@ typedef struct input_stream InputStream;
typedef int (*InputStreamSeekFunc) (struct input_stream *inStream, long offset, typedef int (*InputStreamSeekFunc) (struct input_stream *inStream, long offset,
int whence); int whence);
typedef size_t(*InputStreamReadFunc) (struct input_stream *inStream, void *ptr, typedef size_t(*InputStreamReadFunc) (struct input_stream *inStream, void *ptr,
size_t size, size_t nmemb); size_t size);
typedef int (*InputStreamCloseFunc) (struct input_stream *inStream); typedef int (*InputStreamCloseFunc) (struct input_stream *inStream);
typedef int (*InputStreamAtEOFFunc) (struct input_stream *inStream); typedef int (*InputStreamAtEOFFunc) (struct input_stream *inStream);
typedef int (*InputStreamBufferFunc) (struct input_stream *inStream); typedef int (*InputStreamBufferFunc) (struct input_stream *inStream);
...@@ -67,6 +67,6 @@ int inputStreamAtEOF(struct input_stream *inStream); ...@@ -67,6 +67,6 @@ int inputStreamAtEOF(struct input_stream *inStream);
int bufferInputStream(struct input_stream *inStream); int bufferInputStream(struct input_stream *inStream);
size_t readFromInputStream(struct input_stream *inStream, size_t readFromInputStream(struct input_stream *inStream,
void *ptr, size_t size, size_t nmemb); void *ptr, size_t size);
#endif #endif
...@@ -71,12 +71,11 @@ int inputStream_fileSeek(struct input_stream *inStream, long offset, ...@@ -71,12 +71,11 @@ int inputStream_fileSeek(struct input_stream *inStream, long offset,
} }
size_t inputStream_fileRead(struct input_stream *inStream, size_t inputStream_fileRead(struct input_stream *inStream,
void *ptr, size_t size, void *ptr, size_t size)
size_t nmemb)
{ {
size_t readSize; size_t readSize;
readSize = fread(ptr, size, nmemb, (FILE *) inStream->data); readSize = fread(ptr, 1, size, (FILE *) inStream->data);
if (readSize <= 0 && ferror((FILE *) inStream->data)) { if (readSize <= 0 && ferror((FILE *) inStream->data)) {
inStream->error = errno; inStream->error = errno;
DEBUG("inputStream_fileRead: error reading: %s\n", DEBUG("inputStream_fileRead: error reading: %s\n",
......
...@@ -29,8 +29,7 @@ int inputStream_fileSeek(struct input_stream *inStream, long offset, ...@@ -29,8 +29,7 @@ int inputStream_fileSeek(struct input_stream *inStream, long offset,
int whence); int whence);
size_t inputStream_fileRead(struct input_stream *inStream, size_t inputStream_fileRead(struct input_stream *inStream,
void *ptr, size_t size, void *ptr, size_t size);
size_t nmemb);
int inputStream_fileClose(struct input_stream *inStream); int inputStream_fileClose(struct input_stream *inStream);
......
...@@ -890,11 +890,10 @@ static size_t read_with_metadata(InputStream *is, unsigned char *ptr, ...@@ -890,11 +890,10 @@ static size_t read_with_metadata(InputStream *is, unsigned char *ptr,
return readed; return readed;
} }
size_t inputStream_httpRead(InputStream * is, void *_ptr, size_t size, size_t inputStream_httpRead(InputStream * is, void *_ptr, size_t size)
size_t nmemb)
{ {
struct http_data *data = (struct http_data *) is->data; struct http_data *data = (struct http_data *) is->data;
size_t len = size * nmemb; size_t len = size;
size_t r; size_t r;
unsigned char *ptr = _ptr, *ptr0 = _ptr; unsigned char *ptr = _ptr, *ptr0 = _ptr;
long tries = len / 128; /* try harder for bigger reads */ long tries = len / 128; /* try harder for bigger reads */
......
...@@ -27,8 +27,7 @@ int inputStream_httpOpen(InputStream * inStream, char *filename); ...@@ -27,8 +27,7 @@ int inputStream_httpOpen(InputStream * inStream, char *filename);
int inputStream_httpSeek(InputStream * inStream, long offset, int whence); int inputStream_httpSeek(InputStream * inStream, long offset, int whence);
size_t inputStream_httpRead(InputStream * inStream, void *ptr, size_t size, size_t inputStream_httpRead(InputStream * inStream, void *ptr, size_t size);
size_t nmemb);
int inputStream_httpClose(InputStream * inStream); int inputStream_httpClose(InputStream * inStream);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment