update: print error when opendir() fails

MPD used to be silent when it could stat() a directory, but could not opendir() it to read its contents. This caused a lot of support headache with users who have wrong file permissions. Add another warning message.

update: print error when opendir() fails
53271e8a · Max Kellermann · 497c0b1c · 53271e8a
Commit 53271e8a authored Feb 27, 2009 by Max Kellermann
Show whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

update.c src/update.c +6 -1

No files found.
--- a/src/update.c
+++ b/src/update.c
@@ -540,9 +540,14 @@ updateDirectory(struct directory *directory, const struct stat *st)
 		return false;

 	dir = opendir(path_fs);
+	if (!dir) {
+		g_warning("Failed to open directory %s: %s",
+			  path_fs, g_strerror(errno));
 		g_free(path_fs);
-	if (!dir)
 		return false;
+	}
+
+	g_free(path_fs);

 	removeDeletedFromDirectory(directory);