[clang-tidy] remove pointless void arg

Found with modernize-redundant-void-arg Signed-off-by: 's avatarRosen Penev <rosenp@gmail.com>
parent bc6eca21
...@@ -107,7 +107,7 @@ static constexpr OptionDef option_defs[] = { ...@@ -107,7 +107,7 @@ static constexpr OptionDef option_defs[] = {
static constexpr Domain cmdline_domain("cmdline"); static constexpr Domain cmdline_domain("cmdline");
gcc_noreturn gcc_noreturn
static void version(void) static void version()
{ {
printf("Music Player Daemon " VERSION " (%s)" printf("Music Player Daemon " VERSION " (%s)"
"\n" "\n"
...@@ -273,7 +273,7 @@ static void PrintOption(const OptionDef &opt) ...@@ -273,7 +273,7 @@ static void PrintOption(const OptionDef &opt)
} }
gcc_noreturn gcc_noreturn
static void help(void) static void help()
{ {
printf("Usage:\n" printf("Usage:\n"
" mpd [OPTION...] [path/to/mpd.conf]\n" " mpd [OPTION...] [path/to/mpd.conf]\n"
......
...@@ -63,7 +63,7 @@ static void redirect_logs(int fd) ...@@ -63,7 +63,7 @@ static void redirect_logs(int fd)
} }
static int static int
open_log_file(void) open_log_file()
{ {
assert(!out_path.IsNull()); assert(!out_path.IsNull());
......
...@@ -73,7 +73,7 @@ archive_plugin_from_name(const char *name) noexcept ...@@ -73,7 +73,7 @@ archive_plugin_from_name(const char *name) noexcept
return nullptr; return nullptr;
} }
void archive_plugin_init_all(void) void archive_plugin_init_all()
{ {
for (unsigned i = 0; archive_plugins[i] != nullptr; ++i) { for (unsigned i = 0; archive_plugins[i] != nullptr; ++i) {
const ArchivePlugin *plugin = archive_plugins[i]; const ArchivePlugin *plugin = archive_plugins[i];
......
...@@ -330,7 +330,7 @@ mpd_inotify_init(EventLoop &loop, Storage &storage, UpdateService &update, ...@@ -330,7 +330,7 @@ mpd_inotify_init(EventLoop &loop, Storage &storage, UpdateService &update,
} }
void void
mpd_inotify_finish(void) noexcept mpd_inotify_finish() noexcept
{ {
if (inotify_source == nullptr) if (inotify_source == nullptr)
return; return;
......
...@@ -102,7 +102,7 @@ flac_scan_stream(InputStream &is, TagHandler &handler) noexcept ...@@ -102,7 +102,7 @@ flac_scan_stream(InputStream &is, TagHandler &handler) noexcept
* Some glue code around FLAC__stream_decoder_new(). * Some glue code around FLAC__stream_decoder_new().
*/ */
static FlacStreamDecoder static FlacStreamDecoder
flac_decoder_new(void) flac_decoder_new()
{ {
FlacStreamDecoder sd; FlacStreamDecoder sd;
if(!FLAC__stream_decoder_set_metadata_respond(sd.get(), FLAC__METADATA_TYPE_VORBIS_COMMENT)) if(!FLAC__stream_decoder_set_metadata_respond(sd.get(), FLAC__METADATA_TYPE_VORBIS_COMMENT))
......
...@@ -38,24 +38,24 @@ static constexpr Domain mikmod_domain("mikmod"); ...@@ -38,24 +38,24 @@ static constexpr Domain mikmod_domain("mikmod");
static constexpr size_t MIKMOD_FRAME_SIZE = 4096; static constexpr size_t MIKMOD_FRAME_SIZE = 4096;
static BOOL static BOOL
mikmod_mpd_init(void) mikmod_mpd_init()
{ {
return VC_Init(); return VC_Init();
} }
static void static void
mikmod_mpd_exit(void) mikmod_mpd_exit()
{ {
VC_Exit(); VC_Exit();
} }
static void static void
mikmod_mpd_update(void) mikmod_mpd_update()
{ {
} }
static BOOL static BOOL
mikmod_mpd_is_present(void) mikmod_mpd_is_present()
{ {
return true; return true;
} }
......
...@@ -162,7 +162,7 @@ parse_cdio_uri(const char *src) ...@@ -162,7 +162,7 @@ parse_cdio_uri(const char *src)
} }
static AllocatedPath static AllocatedPath
cdio_detect_device(void) cdio_detect_device()
{ {
char **devices = cdio_get_devices_with_cap(nullptr, CDIO_FS_AUDIO, char **devices = cdio_get_devices_with_cap(nullptr, CDIO_FS_AUDIO,
false); false);
......
...@@ -80,7 +80,7 @@ audio_output_state_read(const char *line, MultipleOutputs &outputs) ...@@ -80,7 +80,7 @@ audio_output_state_read(const char *line, MultipleOutputs &outputs)
} }
unsigned unsigned
audio_output_state_get_version(void) audio_output_state_get_version()
{ {
return audio_output_state_version; return audio_output_state_version;
} }
...@@ -419,7 +419,7 @@ JackOutput::Connect() ...@@ -419,7 +419,7 @@ JackOutput::Connect()
} }
static bool static bool
mpd_jack_test_default_device(void) mpd_jack_test_default_device()
{ {
return true; return true;
} }
......
...@@ -872,7 +872,7 @@ try { ...@@ -872,7 +872,7 @@ try {
} }
static bool static bool
pulse_output_test_default_device(void) pulse_output_test_default_device()
{ {
return PulseOutput::TestDefaultDevice(); return PulseOutput::TestDefaultDevice();
} }
......
...@@ -66,7 +66,7 @@ static bool had_group = false; ...@@ -66,7 +66,7 @@ static bool had_group = false;
static int detach_fd = -1; static int detach_fd = -1;
void void
daemonize_kill(void) daemonize_kill()
{ {
if (pidfile.IsNull()) if (pidfile.IsNull())
throw std::runtime_error("no pid_file specified in the config file"); throw std::runtime_error("no pid_file specified in the config file");
...@@ -85,14 +85,14 @@ daemonize_kill(void) ...@@ -85,14 +85,14 @@ daemonize_kill(void)
} }
void void
daemonize_close_stdin(void) daemonize_close_stdin()
{ {
close(STDIN_FILENO); close(STDIN_FILENO);
open("/dev/null", O_RDONLY); open("/dev/null", O_RDONLY);
} }
void void
daemonize_set_user(void) daemonize_set_user()
{ {
if (user_name == nullptr) if (user_name == nullptr)
return; return;
...@@ -245,7 +245,7 @@ daemonize_init(const char *user, const char *group, AllocatedPath &&_pidfile) ...@@ -245,7 +245,7 @@ daemonize_init(const char *user, const char *group, AllocatedPath &&_pidfile)
} }
void void
daemonize_finish(void) daemonize_finish()
{ {
if (!pidfile.IsNull()) { if (!pidfile.IsNull()) {
unlink(pidfile.c_str()); unlink(pidfile.c_str());
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment