meson.build: disable -Wsuggest-override with GCC 8

56c0733b · Max Kellermann · 0b0acb39 · 56c0733b
Commit 56c0733b authored 4 years ago by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

meson.build meson.build +6 -1

No files found.
--- a/meson.build
+++ b/meson.build
@@ -72,7 +72,6 @@ test_cxxflags = test_common_flags + [
  '-Woverloaded-virtual',
  '-Wshadow',
  '-Wsign-promo',
-  '-Wsuggest-override',
  '-Wunused',
  '-Wvolatile',
  '-Wvirtual-inheritance',
@@ -89,6 +88,12 @@ test_cxxflags = test_common_flags + [
  '-Wused-but-marked-unused',
 ]

+if compiler.get_id() != 'gcc' or compiler.version().version_compare('>=9')
+  # The GCC 8 implementation of this flag is buggy: it complains even
+  # if "final" is present, which implies "override".
+  test_cxxflags += '-Wsuggest-override'
+endif
+
 test_cflags = test_common_flags + [
  '-Wcast-qual',
  '-Wmissing-prototypes',