input/curl: fixed endless loop during buffering

When the connection is lost while buffering, the CURL input plugin may enter an endless loop, because it does not check the EOF condition. This patch makes fill_buffer() return success only if there's at least one buffer, which is enough of a check.x

input/curl: fixed endless loop during buffering
6037beab · Max Kellermann · 9a3f5ff9 · 6037beab · 6037beab
Commit 6037beab authored Oct 13, 2009 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

NEWS NEWS +1 -0

curl_input_plugin.c src/input/curl_input_plugin.c +1 -1

No files found.
--- a/NEWS
+++ b/NEWS
 ver 0.15.5 (2009/??/??)
 * input:
  - curl: don't abort if a packet has only metadata
+  - curl: fixed endless loop during buffering
 * tags:
  - riff, aiff: fixed "limited range" gcc warning
 * decoder_thread: change the fallback decoder name to "mad"

--- a/src/input/curl_input_plugin.c
+++ b/src/input/curl_input_plugin.c
@@ -315,7 +315,7 @@ fill_buffer(struct input_stream *is)
 			return false;
 	}

-	return true;
+	return !g_queue_is_empty(c->buffers);
 }

 /**