More (v)snprintf-related buffer over-allocations removed

src/log.c

@@ -68,7 +68,7 @@ static const char *log_date(void)
 #define BUFFER_LENGTH	4096
 static void buffer_warning(const char *fmt, va_list args)
 {
-	char buffer[BUFFER_LENGTH + 1];
+	char buffer[BUFFER_LENGTH];
 	char *tmp = buffer;
 	size_t len = BUFFER_LENGTH;
 

src/myfprintf.c

@@ -50,7 +50,7 @@ static void blockingWrite(const int fd, const char *string, size_t len)
 
 void vfdprintf(const int fd, const char *fmt, va_list args)
 {
-	static char buffer[BUFFER_LENGTH + 1];
+	static char buffer[BUFFER_LENGTH];
 	char *buf = buffer;
 	size_t len;
 

src/player.c

@@ -303,8 +303,8 @@ char *getPlayerErrorStr(void)
 	int errorlen = MAXPATHLEN + 1024;
 	PlayerControl *pc = &(getPlayerData()->playerControl);
 
-	error = xrealloc(error, errorlen + 1);
-	memset(error, 0, errorlen + 1);
+	error = xrealloc(error, errorlen);
+	error[0] = '\0';
 
 	switch (pc->error) {
 	case PLAYER_ERROR_FILENOTFOUND: