decoder/ffmpeg: fix double free bug

From the avformat_open_input() API documentation: "Note that a user-supplied AVFormatContext will be freed on failure." https://bugs.musicpd.org/view.php?id=4607

decoder/ffmpeg: fix double free bug
7146f825 · Max Kellermann · f61a5f52 · 7146f825 · 7146f825
Commit 7146f825 authored Dec 13, 2016 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

NEWS NEWS +2 -0

FfmpegDecoderPlugin.cxx src/decoder/plugins/FfmpegDecoderPlugin.cxx +0 -1

No files found.
--- a/NEWS
+++ b/NEWS
 ver 0.19.20 (not yet released)
+* decoder
+  - ffmpeg: fix crash bug

 ver 0.19.20 (2016/12/09)
 * protocol

--- a/src/decoder/plugins/FfmpegDecoderPlugin.cxx
+++ b/src/decoder/plugins/FfmpegDecoderPlugin.cxx
@@ -71,7 +71,6 @@ FfmpegOpenInput(AVIOContext *pb,

 	int err = avformat_open_input(&context, filename, fmt, nullptr);
 	if (err < 0) {
-		avformat_free_context(context);
 		SetFfmpegError(error, err, "avformat_open_input() failed");
 		return nullptr;
 	}