decoder/wavpack: seek errors are fatal

The libWavPack documentation says: "After a FALSE return the file should not be accessed again (other than to close it); this is a fatal error."

decoder/wavpack: seek errors are fatal
7b4305d8 · Max Kellermann · 94e9e93f · 7b4305d8
Commit 7b4305d8 authored Dec 10, 2016 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 4 deletions

WavpackDecoderPlugin.cxx src/decoder/plugins/WavpackDecoderPlugin.cxx +5 -4

No files found.
--- a/src/decoder/plugins/WavpackDecoderPlugin.cxx
+++ b/src/decoder/plugins/WavpackDecoderPlugin.cxx
@@ -217,12 +217,13 @@ wavpack_decode(DecoderClient &client, WavpackContext *wpc, bool can_seek)
 		if (cmd == DecoderCommand::SEEK) {
 			if (can_seek) {
 				auto where = client.GetSeekFrame();
-
-				if (WavpackSeekSample(wpc, where)) {
-					client.CommandFinished();
-				} else {
+				if (!WavpackSeekSample(wpc, where)) {
+					/* seek errors are fatal */
 					client.SeekError();
+					break;
 				}
+
+				client.CommandFinished();
 			} else {
 				client.SeekError();
 			}