event/Loop: AbandonFD() unlinks the SocketEvent

Fixes use-after-free bugs causing assertion failures at shutdown, because all "abandoned" SocketEvents are still in the linked list. Closes https://github.com/MusicPlayerDaemon/MPD/issues/986 Closes https://github.com/MusicPlayerDaemon/MPD/issues/987

event/Loop: AbandonFD() unlinks the SocketEvent
7c47fe74 · Max Kellermann · 65a1c4a0 · 7c47fe74
Commit 7c47fe74 authored Oct 28, 2020 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 0 deletions

Loop.cxx src/event/Loop.cxx +2 -0

No files found.
--- a/src/event/Loop.cxx
+++ b/src/event/Loop.cxx
@@ -110,6 +110,8 @@ EventLoop::AbandonFD(SocketEvent &event)  noexcept
 #endif
 	assert(event.IsDefined());

+	event.unlink();
+
 	return poll_backend.Abandon(event.GetSocket().Get());
 }