Output: start with a null mixer.

There are code paths (mostly error cases) in which it is possible to initialize an AudioOutput and then kill it without ever calling audio_output_new(). In such a case, its destructor will attempt to free a mixer that was never initialized, leading to an attempt to take out a lock on a mutex that was similarly never initialized, which hangs forever. Fix by always initializing the mixer appropriately.

Output: start with a null mixer.
811af02f · Nix · Max Kellermann · 8780e23e · 811af02f
Commit 811af02f authored Nov 24, 2014 by Nix Committed by Max Kellermann Dec 01, 2014
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 0 deletions

Init.cxx src/output/Init.cxx +1 -0

No files found.
--- a/src/output/Init.cxx
+++ b/src/output/Init.cxx
@@ -48,6 +48,7 @@

 AudioOutput::AudioOutput(const AudioOutputPlugin &_plugin)
 	:plugin(_plugin),
+	 mixer(nullptr),
 	 enabled(true), really_enabled(false),
 	 open(false),
 	 pause(false),