Instance: remove Error parameter from GetDatabase()

src/Instance.cxx

@@ -35,15 +35,6 @@
 
 #ifdef ENABLE_DATABASE
 
-Database *
-Instance::GetDatabase(Error &error)
-{
-	if (database == nullptr)
-		error.Set(db_domain, int(DatabaseErrorCode::DISABLED),
-			  "No database");
-	return database;
-}
-
 const Database &
 Instance::GetDatabaseOrThrow() const
 {

src/Instance.hxx

@@ -109,7 +109,9 @@ struct Instance final
 	 * if this MPD configuration has no database (no
 	 * music_directory was configured).
 	 */
-	Database *GetDatabase(Error &error);
+	Database *GetDatabase() {
+		return database;
+	}
 
 	/**
 	 * Returns the global #Database instance.  Throws

src/Partition.cxx

@@ -45,9 +45,9 @@ Partition::EmitIdle(unsigned mask)
 #ifdef ENABLE_DATABASE
 
 const Database *
-Partition::GetDatabase(Error &error) const
+Partition::GetDatabase() const
 {
-	return instance.GetDatabase(error);
+	return instance.GetDatabase();
 }
 
 const Database &

src/Partition.hxx

@@ -183,7 +183,7 @@ struct Partition final : QueueListener, PlayerListener, MixerListener {
 	 * if this MPD configuration has no database (no
 	 * music_directory was configured).
 	 */
-	const Database *GetDatabase(Error &error) const;
+	const Database *GetDatabase() const;
 
 	gcc_pure
 	const Database &GetDatabaseOrThrow() const;

src/SongLoader.cxx

@@ -32,7 +32,7 @@
 #ifdef ENABLE_DATABASE
 
 SongLoader::SongLoader(const Client &_client)
-	:client(&_client), db(_client.GetDatabase(IgnoreError())),
+	:client(&_client), db(_client.GetDatabase()),
 	 storage(_client.GetStorage()) {}
 
 #endif

src/client/Client.cxx

@@ -28,9 +28,9 @@ const Domain client_domain("client");
 #ifdef ENABLE_DATABASE
 
 const Database *
-Client::GetDatabase(Error &error) const
+Client::GetDatabase() const
 {
-	return partition.instance.GetDatabase(error);
+	return partition.instance.GetDatabase();
 }
 
 const Database &

src/client/Client.hxx

@@ -185,7 +185,7 @@ public:
 	 * Wrapper for Instance::GetDatabase().
 	 */
 	gcc_pure
-	const Database *GetDatabase(Error &error) const;
+	const Database *GetDatabase() const;
 
 	/**
 	 * Wrapper for Instance::GetDatabaseOrThrow().

test/test_translate_song.cxx

@@ -131,7 +131,7 @@ DetachedSong::LoadFile(Path path)
 }
 
 const Database *
-Client::GetDatabase(gcc_unused Error &error) const
+Client::GetDatabase() const
 {
 	return reinterpret_cast<const Database *>(this);
 }