Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
M
mpd
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Иван Мажукин
mpd
Commits
a4eed3e3
Unverified
Commit
a4eed3e3
authored
Feb 02, 2020
by
Rosen Penev
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[clang-tidy] use forward instead of move
Found with bugprone-move-forwarding-reference Signed-off-by:
Rosen Penev
<
rosenp@gmail.com
>
parent
140d8547
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
3 deletions
+3
-3
Data.cxx
src/config/Data.cxx
+1
-1
UDisks2.cxx
src/lib/dbus/UDisks2.cxx
+1
-1
UdisksNeighborPlugin.cxx
src/neighbor/plugins/UdisksNeighborPlugin.cxx
+1
-1
No files found.
src/config/Data.cxx
View file @
a4eed3e3
...
...
@@ -50,7 +50,7 @@ template<typename T>
static
auto
Append
(
std
::
forward_list
<
T
>
&
list
,
T
&&
src
)
{
return
list
.
emplace_after
(
FindLast
(
list
),
std
::
move
(
src
));
return
list
.
emplace_after
(
FindLast
(
list
),
std
::
forward
<
T
>
(
src
));
}
void
...
...
src/lib/dbus/UDisks2.cxx
View file @
a4eed3e3
...
...
@@ -167,7 +167,7 @@ ParseObjects(ODBus::ReadMessageIter &&i,
ForEachInterface
(
std
::
move
(
i
),
[
&
callback
](
const
char
*
path
,
auto
&&
j
){
Object
o
(
path
);
ParseObject
(
o
,
std
::
move
(
j
));
ParseObject
(
o
,
std
::
forward
<
decltype
(
j
)
>
(
j
));
if
(
o
.
IsValid
())
callback
(
std
::
move
(
o
));
});
...
...
src/neighbor/plugins/UdisksNeighborPlugin.cxx
View file @
a4eed3e3
...
...
@@ -231,7 +231,7 @@ UdisksNeighborExplorer::HandleMessage(DBusConnection *, DBusMessage *message) no
dbus_message_has_signature
(
message
,
InterfacesAddedType
::
value
))
{
RecurseInterfaceDictEntry
(
ReadMessageIter
(
*
message
),
[
this
](
const
char
*
path
,
auto
&&
i
){
UDisks2
::
Object
o
(
path
);
UDisks2
::
ParseObject
(
o
,
std
::
move
(
i
));
UDisks2
::
ParseObject
(
o
,
std
::
forward
<
decltype
(
i
)
>
(
i
));
if
(
o
.
IsValid
())
this
->
Insert
(
std
::
move
(
o
));
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment