tag: oops, of course items is now ** and not *

Gah, it seems like doing sizeof here either way is error prone. Too easy to leave out a '*' character we can forget.

tag: oops, of course items is now ** and not *
a5f68b3c · Eric Wong · Max Kellermann · 3c4de5b5 · a5f68b3c
Commit a5f68b3c authored Sep 07, 2008 by Eric Wong Committed by Max Kellermann Sep 07, 2008
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

tag.c src/tag.c +2 -2

No files found.
--- a/src/tag.c
+++ b/src/tag.c
@@ -57,7 +57,7 @@ mpd_sint8 ignoreTagItems[TAG_NUM_OF_ITEM_TYPES];

 static size_t items_size(const struct tag *tag)
 {
-	return (tag->numOfItems * sizeof(struct tag_item));
+	return (tag->numOfItems * sizeof(struct tag_item *));
 }

 void tag_lib_init(void)
@@ -427,7 +427,7 @@ static void appendToTagItems(struct tag *tag, enum tag_type type,

 		tag->items = xmalloc(items_size(tag));
 		memcpy(tag->items, bulk.items,
-		       items_size(tag) - sizeof(struct tag_item));
+		       items_size(tag) - sizeof(struct tag_item *));
 	}

 	pthread_mutex_lock(&tag_pool_lock);