stored_playlist: fix integer overflow in length estimation

With a large maximum playlist length, the integer multiplication "playlist_max_length * MPD_PATH_MAX" may overflow. Change that to a division. This was not a dangerous bug, since it was only used for a quick estimate.

stored_playlist: fix integer overflow in length estimation
a94e59ca · Max Kellermann · 7f98ba24 · a94e59ca
Commit a94e59ca authored Dec 24, 2008 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

stored_playlist.c src/stored_playlist.c +1 -1

No files found.
--- a/src/stored_playlist.c
+++ b/src/stored_playlist.c
@@ -338,7 +338,7 @@ spl_append_song(const char *utf8path, struct song *song)
 		return PLAYLIST_RESULT_ERRNO;
 	}

-	if (st.st_size >= ((MPD_PATH_MAX+1) * (off_t)playlist_max_length)) {
+	if (st.st_size / (MPD_PATH_MAX + 1) >= (off_t)playlist_max_length) {
 		while (fclose(file) != 0 && errno == EINTR);
 		return PLAYLIST_RESULT_TOO_LARGE;
 	}