lib/curl/Request: allow Stop() to be called twice

Convert assertion to runtime check. This is useful because this is a public method, and the caller has no chance to check if the object is still registered.

lib/curl/Request: allow Stop() to be called twice
dc53098e · Max Kellermann · 3c66feff · dc53098e
Commit dc53098e authored Jan 08, 2017 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

Request.cxx src/lib/curl/Request.cxx +3 -3

No files found.
--- a/src/lib/curl/Request.cxx
+++ b/src/lib/curl/Request.cxx
@@ -81,7 +81,8 @@ CurlRequest::Start()
 void
 CurlRequest::Stop()
 {
-	assert(registered);
+	if (!registered)
+		return;

 	global.Remove(easy.Get());
 	registered = false;
@@ -93,8 +94,7 @@ CurlRequest::FreeEasy()
 	if (!easy)
 		return;

-	if (registered)
-		Stop();
+	Stop();
 	easy = nullptr;
 }