don't repeat select()

The interfaces main loop repeats the select() (non-blocking) after an event was handled. I do not see any reason for that, since all events should be handled after the first select(). This double select() does nothing than consume more CPU cycles. git-svn-id: https://svn.musicpd.org/mpd/trunk@7213 09075e82-0dd4-0310-85a5-a0d7c8717e4f

don't repeat select()
e4779fa7 · Max Kellermann · Eric Wong · f9e317cc · e4779fa7
Commit e4779fa7 authored Mar 26, 2008 by Max Kellermann Committed by Eric Wong Mar 26, 2008
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 5 deletions

interface.c src/interface.c +2 -5

No files found.
--- a/src/interface.c
+++ b/src/interface.c
@@ -478,7 +478,6 @@ int doIOForInterfaces(void)
 	fd_set rfds;
 	fd_set wfds;
 	fd_set efds;
-	struct timeval tv, *tvp = NULL;
 	int i;
 	int selret;
 	int fdmax;
@@ -492,7 +491,7 @@ int doIOForInterfaces(void)

 		registered_IO_add_fds(&fdmax, &rfds, &wfds, &efds);

-		selret = select(fdmax + 1, &rfds, &wfds, &efds, tvp);
+		selret = select(fdmax + 1, &rfds, &wfds, &efds, NULL);

 		if (selret < 0 && errno == EINTR)
 			break;
@@ -525,9 +524,7 @@ int doIOForInterfaces(void)
 			}
 		}

-		tv.tv_sec = 0;
-		tv.tv_usec = 0;
-		tvp = &tv;
+		break;
 	}

 	return 1;