notify: make notify_init() failures fatal

When a mutex cannot be created, there must be something very wrong. Induce panic and abort MPD in this case.

notify: make notify_init() failures fatal
ee1d723a · Max Kellermann · 770b1405 · ee1d723a · ee1d723a
Commit ee1d723a authored Sep 24, 2008 by Max Kellermann
Show whitespace changes
Inline Side-by-side

Showing with 6 additions and 9 deletions

notify.c src/notify.c +5 -8

notify.h src/notify.h +1 -1

No files found.
--- a/src/notify.c
+++ b/src/notify.c
@@ -17,24 +17,21 @@
 */

 #include "notify.h"
+#include "log.h"

-int notify_init(struct notify *notify)
+void notify_init(struct notify *notify)
 {
 	int ret;

 	ret = pthread_mutex_init(&notify->mutex, NULL);
 	if (ret != 0)
-		return ret;
+		FATAL("pthread_mutex_init() failed");

 	ret = pthread_cond_init(&notify->cond, NULL);
-	if (ret != 0) {
-		pthread_mutex_destroy(&notify->mutex);
-		return ret;
-	}
+	if (ret != 0)
+		FATAL("pthread_mutex_init() failed");

 	notify->pending = 0;
-
-	return 0;
 }

 void notify_enter(struct notify *notify)

--- a/src/notify.h
+++ b/src/notify.h
@@ -27,7 +27,7 @@ typedef struct notify {
 	int pending;
 } Notify;

-int notify_init(struct notify *notify);
+void notify_init(struct notify *notify);

 /**
 * The thread which shall be notified by this object must call this